Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing VNET support for Azure CLI - Cosmos DB #6135

Merged
merged 7 commits into from
Apr 25, 2018
Merged

Conversation

dmakwana
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@promptws
Copy link

View a preview at https://prompt.ws/r/Azure/azure-cli/6135
This is an experimental preview for @microsoft users.

Copy link
Member

@derekbekoe derekbekoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a test. Also, CI is failing due to a test.

@derekbekoe
Copy link
Member

Please rebase with the latest on dev branch. There was a fix just merged to fix a Travis CI change.

@dmakwana
Copy link
Contributor Author

We can't add a test for this since az cli vnet doesn't support creating a vnet with specifying the service endpoint

@derekbekoe derekbekoe merged commit a74fce7 into Azure:dev Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants