Only apply transformer to table output for lab vm show
#6104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6104 |
|
@ericwol-msft can you review? |
ericwolz
reviewed
Apr 12, 2018
| @@ -83,7 +83,7 @@ def load_command_table(self, _): | |||
| # Virtual Machine Operations Commands | |||
| with self.command_group('lab vm', virtual_machine_operations, | |||
| client_factory=get_devtestlabs_virtual_machine_operation) as g: | |||
| g.command('show', 'get', transform=transform_vm) | |||
| g.command('show', 'get', table_transformer=transform_vm) | |||
There was a problem hiding this comment.
So, does this change also need to be applied to 'lab artifact-source show' and 'lab arm-template show', ?
There was a problem hiding this comment.
Yep, let me double check and make sure all instances of transform and table_transformer are the same as what they were pre- knack conversion
There was a problem hiding this comment.
Also, if this only applies to tables, I'd recommend changing the name of the callable to "transform_vm_table_output". That may have contributed to the original regression.
other regressions
troydai
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6089
Fixes: #5677
This checklist is used to make sure that common guidelines for a pull request are followed.