Resolve batch download of blobs with names starting with forward slash #6069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6069 |
troydai
approved these changes
Apr 10, 2018
| normalized_blob_name = normalize_blob_file_path(None, blob_name) | ||
| if normalized_blob_name in blobs_to_download: | ||
| from knack.util import CLIError | ||
| raise CLIError('Multiple blobs with download path: `{}`'.format(normalized_blob_name)) |
williexu
commented
Apr 10, 2018
| from knack.util import CLIError | ||
| raise CLIError('Multiple blobs with download path: `{}`. As a solution, use the `--pattern` parameter ' | ||
| 'to select for a subset of blobs to download OR utilize the `storage blob download` ' | ||
| 'command instead to download individual blobs.'.format(normalized_blob_name)) |
troydai
approved these changes
Apr 10, 2018
|
good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5837
-blob names starting with forward slashes are treated as relative paths.
-if multiple blob names would resolve to the same local file path, a CLIerror is thrown
This checklist is used to make sure that common guidelines for a pull request are followed.