Expose --socket-timeout for blob uploads and downloads
#6046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6046 |
troydai
suggested changes
Apr 6, 2018
| logger.debug('Getting data service client service_type=%s', service_type.__name__) | ||
| try: | ||
| client_kwargs = {'account_name': account_name, | ||
| 'account_key': account_key, | ||
| 'connection_string': connection_string, | ||
| 'sas_token': sas_token} | ||
| 'sas_token': sas_token, | ||
| 'socket_timeout': socket_timeout} |
There was a problem hiding this comment.
Preferable:
if socket_timeout:
client_kwargs['socket_timeout'] = socket_timeout
Better not to assume default values.
| @@ -57,6 +57,8 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |||
| completer=get_storage_name_completion_list(t_queue_service, 'list_queues')) | |||
| progress_type = CLIArgumentType(help='Include this flag to disable progress reporting for the command.', | |||
| action='store_true', validator=add_progress_callback) | |||
| socket_timeout_type = CLIArgumentType(help='The socket timeout used by the service to regulate data flow.', | |||
| type=int) | |||
There was a problem hiding this comment.
What's the unit? Second or millisecond?
derekbekoe
approved these changes
Apr 9, 2018
troydai
suggested changes
Apr 9, 2018
|
|
||
| container = self.create_container(account_info) | ||
|
|
||
| with self.assertRaises(Exception): |
There was a problem hiding this comment.
CLIException instead of Exception. Narrow down the assertion to make sure real issue is exposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5896
This checklist is used to make sure that common guidelines for a pull request are followed.