Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Completer responsiveness in interactive after command table loaded #5794

Merged
merged 5 commits into from
Mar 13, 2018

Conversation

williexu
Copy link
Contributor


-Completers now kick in as soon as the table is loaded, no need to clear the command line and try commands until completions are seen.
-some logic changes
-updated project file to account for dd75a3c

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

(see Authoring Command Modules)

@promptws
Copy link

View a preview at https://prompt.ws/r/Azure/azure-cli/5794
This is an experimental preview for @microsoft users.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the CI errors are, but if this eliminates the need to press ENTER to refresh then LGTM.

@williexu williexu merged commit 83fb2ae into Azure:dev Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants