Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor] Re-enable Autoscale recorded tests #5762

Merged
merged 5 commits into from
Mar 13, 2018
Merged

[Monitor] Re-enable Autoscale recorded tests #5762

merged 5 commits into from
Mar 13, 2018

Conversation

tjprescott
Copy link
Member

These were converted to LiveScenarioTests in the Autoscale PR because the CI kept failing on them.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [N/A] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • [N/A] Each command and parameter has a meaningful description.
  • [N/A] Each new command has a test.

(see Authoring Command Modules)

@tjprescott tjprescott added this to the Sprint 34 milestone Mar 8, 2018
@tjprescott tjprescott requested a review from troydai March 8, 2018 17:59
@promptws
Copy link

promptws commented Mar 8, 2018

View a preview at https://prompt.ws/r/Azure/azure-cli/5762
This is an experimental preview for @microsoft users.

@tjprescott
Copy link
Member Author

The reason most of these tests failed was:

  1. defaulting logic for admin-username fails on CI (because default there is root). That's why it always passes locally.
  2. Test infrastructure is swallowing the actual error and just tossing out an incredibly unhelpful "AssertionError: the command failed"

@tjprescott tjprescott merged commit d1ada06 into Azure:dev Mar 13, 2018
@tjprescott tjprescott deleted the ReenableAutoscaleTests branch March 13, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants