Turn async persist off when logging in #5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5464 |
yugangw-msft
approved these changes
Feb 2, 2018
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| Release History | |||
| =============== | |||
| 2.0.19 | |||
| ++++++ | |||
| * When logging in, provide non-async flag for Profile to flush tokens to disk. | |||
There was a problem hiding this comment.
I suggest be closer to end users: able to login under interactive mode?
LukaszStem
pushed a commit
to LukaszStem/azure-cli
that referenced
this pull request
Feb 21, 2018
* turn async persist off when logging in * profile history, version bump * renaming * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5452
This change flushes the token information into disk without waiting for the command process to end.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines