Make interaction use azureProfile.json from .azure #5442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5442 |
derekbekoe
reviewed
Feb 1, 2018
| @@ -634,7 +634,7 @@ def cli_execute(self, cmd): | |||
| azure_folder = self.config.config_dir | |||
| if not os.path.exists(azure_folder): | |||
| os.makedirs(azure_folder) | |||
| ACCOUNT.load(os.path.join(azure_folder, 'azureProfile.json')) | |||
| ACCOUNT.load(os.path.join(get_config_dir(), 'azureProfile.json')) | |||
| CONFIG.load(os.path.join(azure_folder, 'az.json')) | |||
| SESSION.load(os.path.join(azure_folder, 'az.sess'), max_age=3600) | |||
There was a problem hiding this comment.
I think all of these should use get_config_dir()?
Looks like azure_folder should be changed instead?
tjprescott
reviewed
Feb 1, 2018
| @@ -3,6 +3,10 @@ | |||
| Release History | |||
| =============== | |||
|
|
|||
| 0.3.16 | |||
| ++++++ | |||
| * Point to azureProfile.json in .azure directory. | |||
There was a problem hiding this comment.
I would recommend: "Fix issue where user is prompted to login when using interactive mode in Cloud Shell."
tjprescott
approved these changes
Feb 1, 2018
LukaszStem
pushed a commit
to LukaszStem/azure-cli
that referenced
this pull request
Feb 21, 2018
* make interaction use azureProfile.json from .azure * history and version bump * azure-folder points to .azure * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5421
az loginfrom the cli caches its subscription and profile inside the ".azure" directory.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
(see Authoring Command Modules)