Added paging support for storage list commands. #5419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5419 |
williexu
force-pushed
the
storagedir
branch
2 times, most recently
from
458b15e to
b11e4bc
Compare
troydai
suggested changes
Jan 30, 2018
| item.next_marker = next_marker | ||
| return item | ||
|
|
||
| return list(map(set_marker, result)) |
There was a problem hiding this comment.
Use list comprehensions instead of map
https://www.safaribooksonline.com/library/view/python-cookbook/0596001673/ch01s11.html
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5419 |
|
Please rebase. And does Aaron have any feedback of this? |
troydai
approved these changes
Feb 7, 2018
derekbekoe
pushed a commit
that referenced
this pull request
Feb 8, 2018
LukaszStem
pushed a commit
to LukaszStem/azure-cli
that referenced
this pull request
Feb 21, 2018
* check if dir exists instead of path * added paging, broke * resolved problems with non-listgenerator provided to transformer * history, setup version, tests * review feedback
LukaszStem
pushed a commit
to LukaszStem/azure-cli
that referenced
this pull request
Feb 21, 2018
* Revert "[AKS] list available k8s versions, add tab completers, refactor code (Azure#5475)" This reverts commit 1326d2f. * Revert "Added paging support for storage list commands. (Azure#5419)" This reverts commit 4e8ba81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3745
-"nextMarker" property added to every result of list output
-
listcommands now have--num-resultand--markeras parameters.-minor fixes, and added tests
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)