{Pylint} Fix consider-using-enumerate #30343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
jiasli
force-pushed
the
consider-using-enumerate
branch
from
7c06459 to
40ac8d8
Compare
jiasli
changed the title
consider-using-enumerate pylint error
jiasli
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd,
evelyn-ys,
calvinhzy,
kairu-ms and
necusjz
as code owners
12 tasks
jiasli
force-pushed
the
consider-using-enumerate
branch
from
40ac8d8 to
93deab6
Compare
jiasli
commented
Dec 10, 2024
jiasli
force-pushed
the
consider-using-enumerate
branch
from
93deab6 to
f0461ea
Compare
jiasli
force-pushed
the
consider-using-enumerate
branch
from
f0461ea to
86bebf3
Compare
evelyn-ys
previously approved these changes
Dec 11, 2024
bebound
reviewed
Dec 11, 2024
| for i in range(len(rp.properties.recovery_point_tier_details)): | ||
| currRpTierDetails = rp.properties.recovery_point_tier_details[i] | ||
| for v in rp.properties.recovery_point_tier_details: | ||
| currRpTierDetails = v |
There was a problem hiding this comment.
for i in range(len(xxx)) is not pythonic at all.
bebound
previously approved these changes
Dec 11, 2024
zhoxing-ms
reviewed
Dec 11, 2024
zhoxing-ms
reviewed
Dec 11, 2024
src/azure-cli/azure/cli/command_modules/vm/azure_stack/_validators.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Xing Zhou <[email protected]>
…tors.py Co-authored-by: Xing Zhou <[email protected]>
zhoxing-ms
approved these changes
Dec 11, 2024
necusjz
approved these changes
Dec 11, 2024
yanzhudd
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finish the unfinished tasks of #20192
Fix
consider-using-enumeratepylint error.