-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARM] az bicep\deployment\stack
: Conditionally enable invariant globalization for Bicep running inside the Azure CLI docker image (#29897)
#29897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
az bicep
, az deployment
, az stack
: Conditionally enable invariant globalization for Bicep running inside the Azure CLI docker image
2c3c3ea
to
acc20a0
Compare
acc20a0
to
dacbeef
Compare
bebound
reviewed
Sep 12, 2024
@shenglol Could you please help review this Bicep related PR? |
bebound
reviewed
Sep 23, 2024
bebound
approved these changes
Oct 8, 2024
zhoxing-ms
approved these changes
Oct 25, 2024
@shenglol Could you please help review the Bicep related PR as well? |
shenglol
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
az bicep
, az deployment
, az stack
: Conditionally enable invariant globalization for Bicep running inside the Azure CLI docker imageaz bicep\deployment\stack
: Conditionally enable invariant globalization for Bicep running inside the Azure CLI docker image (#29897)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARM
az resource/group/lock/tag/deployment/policy/managementapp/account management-group
Auto-Assign
Auto assign by bot
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az bicep
,az deployment
,az stack
Description
Fix for #29828 to conditionally enable invariant globalization for Bicep running inside the Azure CLI docker image.
Testing Guide
See changes to
azure-pipelines.yml
History Notes
[ARM]
az bicep\deployment\stack
: Conditionally enable invariant globalization for Bicep running inside the Azure CLI docker imageThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.