[Redis] Add support for 2023-08-01 #27599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| redis access-policy | sub group redis access-policy added |
||
| redis access-policy-assignment | sub group redis access-policy-assignment added |
||
| redis create | cmd redis create added parameter update_channel |
||
| redis flush | cmd redis flush added |
microsoft-github-policy-service
bot
requested review from
evelyn-ys,
jsntcy,
yonzhan,
zhoxing-ms and
kairu-ms
|
Redis |
evelyn-ys
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
|
Please resolve the conflicts |
added 4 commits
January 17, 2024 07:58
koderjoker
force-pushed
the
kj/release_2023-08-01
branch
from
2415961 to
99527c9
Compare
|
Please also re-record the related tests in network module |
evelyn-ys
reviewed
Jan 19, 2024
evelyn-ys
reviewed
Jan 19, 2024
evelyn-ys
reviewed
Jan 19, 2024
evelyn-ys
reviewed
Jan 19, 2024
evelyn-ys
reviewed
Jan 19, 2024
evelyn-ys
reviewed
Jan 19, 2024
src/azure-cli/azure/cli/command_modules/redis/tests/latest/test_redis_scenario.py
Outdated
Show resolved
Hide resolved
evelyn-ys
reviewed
Jan 19, 2024
| @@ -127,7 +236,7 @@ def test_redis_cache_list_keys(self, resource_group): | |||
| result = self.cmd('az redis list-keys -n {name} -g {rg}').get_output_in_json() | |||
| self.assertTrue(result['primaryKey'] is not None) | |||
| self.assertTrue(result['secondaryKey'] is not None) | |||
| self.cmd('az redis update -n {name} -g {rg} --set "tags.mytag=mytagval"') | |||
| # TODO: self.cmd('az redis update -n {name} -g {rg} --set "tags.mytag=mytagval"') | |||
There was a problem hiding this comment.
May I know why you comment out this update command? Is there anything wrong?
There was a problem hiding this comment.
There is a known bug with update, the fix is rolling out. Once roll out completes I will create another PR to uncomment the TODOs.
evelyn-ys
reviewed
Jan 19, 2024
evelyn-ys
reviewed
Jan 24, 2024
evelyn-ys
reviewed
Jan 24, 2024
Co-authored-by: Yishi Wang <[email protected]>
…/azure-cli into kj/release_2023-08-01
evelyn-ys
approved these changes
Jan 25, 2024
necusjz
approved these changes
Jan 25, 2024
jsntcy
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in this PR
Description
New api version to introduce the following changes:
cache aad enablement
access policy
access policy assignment
History Notes
[Redis] Add support for flush operation
[Redis] Add support for Microsoft Entra Authentication
[Redis] Add support for update channels
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.