[AKS] az aks create/update: Support Blob CSI driver
#24404
Conversation
cvvz
requested review from
zhoxing-ms,
andyliuliming,
jsntcy,
yanzhudd,
jiasli,
evelyn-ys,
kairu-ms,
calvinhzy and
necusjz
as code owners
|
acs |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
|
GA feature from aks-preview, previous PR #5027. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
zhoxing-ms
changed the title
az aks create/update: Support Blob CSI driver
|
@cvvz Could you please resolve the code style issue? |
| @@ -6423,6 +6423,97 @@ def test_aks_create_with_standard_csi_drivers(self, resource_group, resource_gro | |||
| self.is_empty(), | |||
| ]) | |||
|
|
|||
| @AllowLargeResponse() | |||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='centraluseuap', preserve_default_location=True) | |||
| def test_aks_create_with_standard_blob_csi_driver(self, resource_group, resource_group_location): | |||
There was a problem hiding this comment.
Queued a pipeline to test and generate recordings for newly added cases.
| @@ -6423,6 +6423,97 @@ def test_aks_create_with_standard_csi_drivers(self, resource_group, resource_gro | |||
| self.is_empty(), | |||
| ]) | |||
|
|
|||
| @AllowLargeResponse() | |||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='centraluseuap', preserve_default_location=True) | |||
| def test_aks_create_with_standard_blob_csi_driver(self, resource_group, resource_group_location): | |||
There was a problem hiding this comment.
def get_subscription(self, subscription=None): # take id or name subscriptions = self.load_cached_subscriptions() if not subscriptions: raise CLIError(_AZ_LOGIN_MESSAGE) knack.util.CLIError: Please run 'az login' to setup account.
Please upload the recording yaml files for those new tests. Otherwise, CI tasks will fail due to missing yaml file
|
@zhoxing-ms can you make sure the cli command branch is cut off after this PR merged? this is a critical AKS feature, we want to ship it in 11-01 cli command release, thanks. |
@andyzhangx OK, we will try our best to merge it today, so as to catch up the release for this sprint |
|
@andyzhangx This PR has been merged, it can be released in this sprint (11-01) |
Related command
az aks create [--enable-blob-driver]
az aks update [--disable-blob-driver] [--enable-blob-driver]
Description
With the feature, customers can enable/disable the Blob CSI Drivers in their clusters on demand.
Testing Guide
pyttest test_managed_cluster_decorator.py
AZURE_CLI_TEST_MODULES=acs azdev test test_aks_create_with_standard_blob_csi_driver --discover --live
AZURE_CLI_TEST_MODULES=acs azdev test test_aks_create_and_update_with_blob_csi_driver --discover --live
History Notes
[AKS]
az aks create/update: Add new parameters--enable-blob-driverand--disable-blob-driverto enable/disable Blob CSI DriverThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.