{IoT} Test updates for beta branch #22262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
|
IoT |
jiasli
reviewed
May 12, 2022
src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2020_09_01/_test_utils.py
Show resolved
Hide resolved
jiasli
approved these changes
May 13, 2022
jiasli
requested review from
jsntcy,
evelyn-ys,
calvinhzy,
DaeunYim,
andyliuliming and
kairu-ms
as code owners
jiasli
reviewed
May 18, 2022
src/azure-cli/azure/cli/command_modules/iot/tests/latest/test_iot_commands.py
Outdated
Show resolved
Hide resolved
|
Your PR should not modify so many modules. Please pull and rebase code from the remote dev branch first |
|
@vilit1 Please note that if you do not address these comments, CI issues and conflicts in time tomorrow, this PR will not catch up with the release of this sprint, and we will have to postpone it to the release of the next sprint (07-05) |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jiasli
approved these changes
May 19, 2022
zhoxing-ms
approved these changes
May 19, 2022
jiasli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing updates, specifically rerecording tests and ensuring that commands would work.
#22174
Additional Changes:
Tests not rerecorded:
Testing Guide
Used
azdev test <command> --profile <profile> --liveto rerecord testsHistory Notes
[IOT] Test updates for beta branch
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.