-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Packaging} Bump PyNaCl from 1.4.0 to 1.5.0 to support arm64 wheel installation #22167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution tbugfinder! We will review the pull request and get back to you soon. |
Packaging |
@tbugfinder, thanks a lot for the contribution! |
jiasli
approved these changes
Apr 25, 2022
PyNaCl is used by
@panchagnula @jsntcy @zhoxing-ms, please help verify if the latest version of PyNaCl works correctly. |
wangzelin007
approved these changes
Apr 25, 2022
jsntcy
approved these changes
Apr 27, 2022
Confirmed new version is working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Auto-Assign
Auto assign by bot
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
Packaging
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref:
#7368
PyNaCl 1.5.0 provides pre-built wheel installation also form arm64 architecture, so the installation is more efficient than building it every time needed.
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.