{PolicyInsights} Update SDK package `azure-mgmt-policyinsights` to `1.1.0b2` #22043

najagasi · 2022-04-13T00:50:17Z

Description
This PR upgrades the azure-mgmt-policyinsights library to version 1.1.0b2 from 1.0.0
Testing Guide

History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

yonzhan · 2022-04-13T01:01:05Z

AzurePolicy

wangzelin007 · 2022-04-13T01:51:09Z

@najagasi,
Please rerun the following tests:
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_complete
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_management_group
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_policy_set
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_reevaluate

zhoxing-ms · 2022-04-20T07:46:13Z

@najagasi Any update?

zhoxing-ms · 2022-04-20T07:49:20Z

src/azure-cli/requirements.py3.windows.txt

-azure-mgmt-policyinsights==1.0.0
+azure-mgmt-policyinsights==1.1.0b2


Why the SDK package is a beta version?

this is the latest python sdk version https://pypi.org/project/azure-mgmt-policyinsights/1.1.0b2/

@najagasi In fact, what I want to ask is why the latest SDK version is a beta version, is because it contains some unstable features or big changes?
If so, will it affect the existing commands?

this fixes an issue we had ran into wherein the python sdk was making GET calls for nextLink instead of POST calls. Fix was needed in Policy Insights swagger and
py sdk release

in this PR bumping it to 1.1.0b2 fixes the issue in cli

zhoxing-ms · 2022-04-21T08:30:40Z

@najagasi Could you address these comments by tomorrow? If not, this PR will not be able to catch up with the release of the sprint, and it can only be postponed to the next sprint (05-24)

najagasi · 2022-04-25T18:33:08Z

Working on the feedback

najagasi · 2022-04-26T20:57:21Z

reran and committed

zhoxing-ms · 2022-04-27T03:39:23Z

Why did you remove these yaml files?

In addition, there are still some tests that fail in CI due to the api-version of Microsoft.PolicyInsights for _remediations_operations used by SDK package is upgraded from 2019-07-01 to 2021-10-01, which require you to record in live mode and then push it to this PR:

FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_complete
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_management_group
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_policy_set
FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights_remediation_reevaluate

najagasi · 2022-05-05T20:46:42Z

@zhoxing-ms I notive that my tests are passing in live mode in local but when it seems like its failing here.
Any suggestions ?

zhoxing-ms · 2022-05-06T06:24:04Z

Please note that the api-version from yaml file you uploaded is not updated. You may need to make sure that the 1.1.0b2 version package is installed correctly in your local environment

Please make sure that the api-version you use when executing the test locally in live mode is 2021-10-01 instead of the old api-version 2019-07-01

najagasi · 2022-05-10T00:55:57Z

@zhoxing-ms thanks for your feeback, i updated the version in my local and reran the tests.
What else might I be missing ?

zhoxing-ms · 2022-05-10T03:33:17Z

FAILED src/azure-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py::PolicyInsightsTests::test_policy_insights

@najagasi Please re-record the yaml file for this test test_policy_insights

najagasi · 2022-05-10T23:41:20Z

i notice this CannotOverwriteExistingCassetteException, how can I resolve this ?

I generally run this command in my local, once the test is passed I add @record_only on the test and then push it.
azdev test test_policy_insights --live

Is there any other command or flow that i should follow ?

zhoxing-ms · 2022-05-11T06:56:18Z

@najagasi Did you temporarily remove the @record_only when re-recording the yaml file of test_policy_insights?

najagasi · 2022-05-11T18:01:24Z

Yes i deleted the yaml file, removed the @record only, ran the test with live, add the @record only.

zhoxing-ms · 2022-05-12T03:12:08Z

...re-cli/azure/cli/command_modules/policyinsights/tests/latest/test_policyinsights_scenario.py

-            '--resource "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cheggpolicy/providers/microsoft.keyvault/vaults/cheggtmpkv"',
-            '--resource "cheggkv" --namespace "microsoft.keyvault" --resource-type "vaults" -g "cheggpolicy"',
-            '--resource "subnet2" --namespace "microsoft.network" --resource-type "subnets" --parent "virtualnetworks/cheggvnet" -g "cheggpolicy"',
-            '-s "1f3afdf9-d0c9-4c3d-847f-89da613e70a8"',
-            '-d "34c877ad-507e-4c82-993e-3452a6e0ad3c"',
-            '-a "4d31128e32d04a0098fd536e"',
-            '-a "f32eeddfc32345b585f9a70b" -g "cheggpolicy" '
+            '-g {resourceGroup}',
+            '--resource "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroup}/providers/microsoft.keyvault/vaults/{keyVault}"',


@najagasi Why do you want to replace the subscription id from 00000000-0000-0000-0000-000000000000 to 3593b919-b078-4cc1-902f-201232a97ac0? Please don't replace it and try again

this fixed it, thank you!

najagasi · 2022-05-12T06:31:45Z

Please do not merge this yet

najagasi · 2022-05-12T22:08:17Z

We are good to merge this

Update policy insights version

cac09a2

yonzhan requested a review from zhoxing-ms April 13, 2022 01:02

yonzhan assigned zhoxing-ms Apr 13, 2022

yonzhan added this to the Apr 2022 (2022-04-26) milestone Apr 13, 2022

yonzhan requested review from wangzelin007 and jsntcy April 13, 2022 01:03

zhoxing-ms reviewed Apr 20, 2022

View reviewed changes

zhoxing-ms modified the milestones: Apr 2022 (2022-04-26), May 2022 (2022-05-24) - For Build Apr 22, 2022

Rerun tests

ae72c2e

zhoxing-ms changed the title ~~[AzurePolicy] Update policy insights version~~ {PolicyInsights} Update SDK package azure-mgmt-policyinsights to 1.1.0b2 Apr 27, 2022

Namrata Jagasia added 2 commits May 5, 2022 11:00

Re ran tests

c417498

ran pi test

5b3b17d

Fix the version and rerun tests in local

0f8b7d9

Namrata Jagasia added 3 commits May 9, 2022 22:41

re run az policy insights test

52285d0

re run az policy insights test again

fa0e37f

uncomment record only

6218cf9

re record test

ee33279

zhoxing-ms reviewed May 12, 2022

View reviewed changes

fix the subscriptionId in test

1f85ef4

najagasi changed the title ~~{PolicyInsights} Update SDK package azure-mgmt-policyinsights to 1.1.0b2~~ [do-not-merge]{PolicyInsights} Update SDK package azure-mgmt-policyinsights to 1.1.0b2 May 12, 2022

yonzhan added the do-not-merge label May 12, 2022

najagasi changed the title ~~[do-not-merge]{PolicyInsights} Update SDK package azure-mgmt-policyinsights to 1.1.0b2~~ {PolicyInsights} Update SDK package azure-mgmt-policyinsights to 1.1.0b2 May 12, 2022

zhoxing-ms approved these changes May 13, 2022

View reviewed changes

zhoxing-ms merged commit b4881c2 into Azure:dev May 13, 2022

HansZimmer5000 mentioned this pull request Jun 8, 2022

Unsupported resource type: 'Microsoft.PolicyInsights/policyStates/queryResults' #22173

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{PolicyInsights} Update SDK package `azure-mgmt-policyinsights` to `1.1.0b2` #22043

{PolicyInsights} Update SDK package `azure-mgmt-policyinsights` to `1.1.0b2` #22043

najagasi commented Apr 13, 2022 •

edited

Loading

yonzhan commented Apr 13, 2022

wangzelin007 commented Apr 13, 2022

zhoxing-ms commented Apr 20, 2022

zhoxing-ms Apr 20, 2022

najagasi Apr 25, 2022

zhoxing-ms Apr 27, 2022 •

edited

Loading

najagasi May 12, 2022

zhoxing-ms commented Apr 21, 2022 •

edited

Loading

najagasi commented Apr 25, 2022

najagasi commented Apr 26, 2022

zhoxing-ms commented Apr 27, 2022 •

edited

Loading

najagasi commented May 5, 2022

zhoxing-ms commented May 6, 2022 •

edited

Loading

najagasi commented May 10, 2022

zhoxing-ms commented May 10, 2022

najagasi commented May 10, 2022 •

edited

Loading

zhoxing-ms commented May 11, 2022

najagasi commented May 11, 2022

zhoxing-ms May 12, 2022 •

edited

Loading

najagasi May 12, 2022

najagasi commented May 12, 2022

najagasi commented May 12, 2022

		azure-mgmt-policyinsights==1.0.0
		azure-mgmt-policyinsights==1.1.0b2

{PolicyInsights} Update SDK package azure-mgmt-policyinsights to 1.1.0b2 #22043

{PolicyInsights} Update SDK package azure-mgmt-policyinsights to 1.1.0b2 #22043

Conversation

najagasi commented Apr 13, 2022 • edited Loading

yonzhan commented Apr 13, 2022

wangzelin007 commented Apr 13, 2022

zhoxing-ms commented Apr 20, 2022

zhoxing-ms Apr 20, 2022

Choose a reason for hiding this comment

najagasi Apr 25, 2022

Choose a reason for hiding this comment

zhoxing-ms Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

najagasi May 12, 2022

Choose a reason for hiding this comment

zhoxing-ms commented Apr 21, 2022 • edited Loading

najagasi commented Apr 25, 2022

najagasi commented Apr 26, 2022

zhoxing-ms commented Apr 27, 2022 • edited Loading

najagasi commented May 5, 2022

zhoxing-ms commented May 6, 2022 • edited Loading

najagasi commented May 10, 2022

zhoxing-ms commented May 10, 2022

najagasi commented May 10, 2022 • edited Loading

zhoxing-ms commented May 11, 2022

najagasi commented May 11, 2022

zhoxing-ms May 12, 2022 • edited Loading

Choose a reason for hiding this comment

najagasi May 12, 2022

Choose a reason for hiding this comment

najagasi commented May 12, 2022

najagasi commented May 12, 2022

{PolicyInsights} Update SDK package `azure-mgmt-policyinsights` to `1.1.0b2` #22043

{PolicyInsights} Update SDK package `azure-mgmt-policyinsights` to `1.1.0b2` #22043

najagasi commented Apr 13, 2022 •

edited

Loading

zhoxing-ms Apr 27, 2022 •

edited

Loading

zhoxing-ms commented Apr 21, 2022 •

edited

Loading

zhoxing-ms commented Apr 27, 2022 •

edited

Loading

zhoxing-ms commented May 6, 2022 •

edited

Loading

najagasi commented May 10, 2022 •

edited

Loading

zhoxing-ms May 12, 2022 •

edited

Loading