-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Release} Fix CI issue for release branch #21277
Merged
zhoxing-ms
merged 3 commits into
Azure:release
from
zhoxing-ms:fix_CI_issue_for_release
Feb 14, 2022
Merged
{Release} Fix CI issue for release branch #21277
zhoxing-ms
merged 3 commits into
Azure:release
from
zhoxing-ms:fix_CI_issue_for_release
Feb 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoxing-ms
requested review from
jsntcy,
wangzelin007,
kairu-ms and
jiasli
as code owners
February 14, 2022 01:56
wangzelin007
approved these changes
Feb 14, 2022
evelyn-ys
approved these changes
Feb 14, 2022
kairu-ms
approved these changes
Feb 14, 2022
jsntcy
approved these changes
Feb 14, 2022
jiasli
approved these changes
Feb 14, 2022
jiasli
requested changes
Feb 14, 2022
@@ -43,8 +43,7 @@ RUN apk add --no-cache bash openssh ca-certificates jq curl openssl perl git zip | |||
ARG JP_VERSION="0.1.3" | |||
|
|||
RUN curl -L https://github.com/jmespath/jp/releases/download/${JP_VERSION}/jp-linux-amd64 -o /usr/local/bin/jp \ | |||
&& chmod +x /usr/local/bin/jp \ | |||
&& pip install --no-cache-dir --upgrade jmespath-terminal | |||
&& chmod +x /usr/local/bin/jp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#21206 is a breaking change and should be included in release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
calvinhzy
approved these changes
Feb 14, 2022
jiasli
approved these changes
Feb 14, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick from dev branch:
jmespath-terminal
from docker image #21206centos7
#212072.1.17
for cred scan #21230Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change.[Component Name 2]
az command b
: Add some customer-facing feature.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.