-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Service] BREAKING CHANGE: az webapp list-runtimes
: Use new stacks APIs
#21057
[App Service] BREAKING CHANGE: az webapp list-runtimes
: Use new stacks APIs
#21057
Conversation
…create/up still WIP
App Service |
@StrawnSC & @calvinsID ,Regarding DIR path & file paths handling - whatever we do should work across windows/ Linux/ all OS file systems. Expecting the path to be a certain format is incorrect. Whatever fixes you do here ensure - doesn't cause any regressions - I recommend keeping this change targeted to Stacks API only & use another PR,, for unrelated changes/ fixes. |
Thanks for making the fix for removing the "/". If there are further fixes needed for gh actions (especially if the workflow file needs any changes) I'm thinking we can do those in a later PR Edit: Or we can do all the changes in later PR as well |
@panchagnula here's the output without an |
@StrawnSC This is a known issue jmespath/jmespath.terminal#19 related to |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhoxing-ms thanks for the help with the CI issues. Was the credential scan check changed recently? It was passing last week on the test recordings, but now it appears to be failing |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@zhoxing-ms any chance we could get this merged soon? @panchagnula has another big upcoming change that's blocked until this is in dev |
az webapp list-runtimes
: Use new stacks APIs
Description
Changes the commands
az webapp up
,az webapp create
andaz webapp list-runtimes
to use web app stacks from the API rather than a hardcoded list.Also does the same for
az functionapp create
and creates a new commandaz functionapp list-runtimes
. Note that the commandaz functionapp list-runtimes
has more verbose output that it's webapp equivalent because function app stacks availability depends on the functions version (v3, v4, etc).Unrelated to the other changes, this also uses the
:
delimiter foraz webapp list-runtimes
instead of|
to avoid PowerShell issues.Currently*, the webapp stacks that will no longer be supported are as follows:
*These lists will change over time since the values will be set by the API.
Example Usage
az webapp list-runtimes
output using no arguments:az webapp list-runtimes
output using--os
argument:az functionapp list-runtimes
output without an--os
argument:az functionapp list-runtimes
output with an--os
argument:Testing Guide
azdev test --live test_webapp_up_commands test_webapp_commands
azdev test --live test_functionapp_commands
History Notes
[App Service] BREAKING CHANGE:
az webapp up
: Change supported runtimes[App Service] BREAKING CHANGE:
az webapp create
: Change supported runtimes[App Service] BREAKING CHANGE:
az webapp list-runtimes
: Add--os
/--os-type
argument, change runtimes, change default behavior to return both linux and windows stacks, and deprecate--linux
argument[App Service] BREAKING CHANGE:
az functionapp create
: Take runtime names and versions from API instead of hardcoded list[App Service]
az functionapp list-runtimes
: Add new command to show function app runtimes, versions, and compatible functions versionsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.