Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Upgrade virtualenv to 16.7.11 to fix install on python 3.10 #20714

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

pallxk
Copy link
Contributor

@pallxk pallxk commented Dec 13, 2021

pypa/virtualenv#2109
https://virtualenv.pypa.io/en/legacy/changes.html#v16-7-11-2021-07-20

Description

Linux install script is not working with Python 3.10 (#20713) due to the fact the version of virutalenv is pinned to 16.7.7, which is not compatible with python 3.10. This PR upgrades virtualenv to 16.7.11.

Testing Guide

docker run --rm -it python:3.10 bash

# errored out
curl -o install_old.py https://raw.githubusercontent.com/Azure/azure-cli/azure-cli-2.31.0/scripts/curl_install_pypi/install.py
python install_old.py

# works
curl -o install_new.py https://raw.githubusercontent.com/pallxk/azure-cli/fix-install-script-py-3.10/scripts/curl_install_pypi/install.py
python install_new.py

History Notes

[Packaging] Fix install script on Python 3.10


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Dec 13, 2021
@ghost
Copy link

ghost commented Dec 13, 2021

Thank you for your contribution pallxk! We will review the pull request and get back to you soon.

@jiasli jiasli self-assigned this Dec 15, 2021
@jiasli
Copy link
Member

jiasli commented Dec 15, 2021

Thanks a lot for the contribution. BTW, this is another evidence showing perhaps we should drop these files (#20476).

@jiasli jiasli changed the title [Packaging] Upgrade virtualenv to 16.7.11 to fix install on python 3.10 {Packaging} Upgrade virtualenv to 16.7.11 to fix install on python 3.10 Dec 15, 2021
@jiasli jiasli merged commit acd7780 into Azure:dev Dec 15, 2021
@pallxk pallxk deleted the fix-install-script-py-3.10 branch March 2, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants