Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Pin cffi to 1.14.6 for RPM #20608

Merged
merged 1 commit into from
Dec 6, 2021
Merged

{Packaging} Pin cffi to 1.14.6 for RPM #20608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,9 +680,6 @@ jobs:

- job: BuildYumPackage
displayName: Build Yum Package

dependsOn: BuildPythonWheel
condition: and(succeeded(), in(variables['Build.Reason'], 'IndividualCI', 'BatchedCI', 'Manual', 'Schedule'))
Comment on lines -683 to -685
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should build RPM/Yum for PRs, like we build MSI for PRs. Otherwise, issue like this can't be discovered by PR, but only after the PR gets merged.

pool:
vmImage: 'ubuntu-20.04'
steps:
Expand Down
5 changes: 4 additions & 1 deletion scripts/release/rpm/azure-cli.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@ A great cloud needs great tools; we're excited to introduce Azure CLI,
# Create a fully instantiated virtual environment, ready to use the CLI.
%{python_cmd} -m venv %{buildroot}%{cli_lib_dir}
source %{buildroot}%{cli_lib_dir}/bin/activate
%{python_cmd} -m pip install --upgrade pip==21.0.1
%{python_cmd} -m pip install --upgrade pip
source %{repo_path}/scripts/install_full.sh

# cffi 1.15.0 doesn't work with RPM: https://foss.heptapod.net/pypy/cffi/-/issues/513
%{python_cmd} -m pip install cffi==1.14.6

deactivate

# Fix up %{buildroot} appearing in some files...
Expand Down