[Synapse] az synapse: Add for managed private endpoints commands #19117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Synapse |
evelyn-ys
reviewed
Aug 12, 2021
Comment on lines
489
to
491
| g.custom_command('create', 'create_Managed_private_endpoints', supports_no_wait=True) | ||
| g.custom_command('list', 'list_Managed_private_endpoints') | ||
| g.custom_command('delete', 'delete_Managed_private_endpoints', confirmation=True, supports_no_wait=True) |
There was a problem hiding this comment.
Both create and delete support no wait but there seems no wait command
There was a problem hiding this comment.
api doesn't suport wait command, so delete supports_no_wait=True.
idear1203
suggested changes
Aug 12, 2021
src/azure-cli/azure/cli/command_modules/synapse/tests/latest/test_synapse_scenario.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/synapse/tests/latest/test_synapse_scenario.py
Outdated
Show resolved
Hide resolved
|
@evelyn-ys @idear1203 please take time to review my new commit, thanks. |
jsntcy
approved these changes
Aug 18, 2021
jiasli
reviewed
Oct 8, 2021
| @@ -134,6 +134,7 @@ | |||
| 'azure-synapse-accesscontrol~=0.5.0', | |||
| 'azure-synapse-artifacts~=0.6.0', | |||
| 'azure-synapse-spark~=0.2.0', | |||
| 'azure-synapse-managedprivateendpoints~=0.3.0', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add synapse managed private endpoints commands. Included create, show, list and delete managed-private-endpoints.
Add azure-synapse-managedprivateendpoints =0.3.0
Testing Guide
History Notes
[Synapse] az synapse: Add managed private endpoints feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.