-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{core} Fix #17170: Replace distutils.version.LooseVersion with packaging.version.parse #17667
Conversation
Replace distutils.version.LooseVersion with packaging.version.Version
@jiasli for awareness |
You need to add |
What are the differences among |
|
Use flexible compatible version range in setup.py Co-authored-by: Feng Zhou <[email protected]>
@@ -352,10 +352,10 @@ def _print(val=''): | |||
print(val, file=output) | |||
|
|||
def _get_version_string(name, version_dict): | |||
from distutils.version import LooseVersion # pylint: disable=import-error,no-name-in-module | |||
from packaging.version import parse # pylint: disable=import-error,no-name-in-module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP 632 also mentions:
distutils.version
— use thepackaging
package
Description
Replace distutils.version.LooseVersion with packaging.version.Version
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.