Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Upgrade pip version in RPM #17178

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

finlaysawyer
Copy link
Contributor

Description
Upgrade pip version to 21.0.1 in bundled Python to solve some extension install/usage issues like #16858

This PR continues on from the work done in #17091, also upgrading pip for RPM distros such as CentOS.

Testing Guide
Verify the new pip version by checking the installation: /usr/lib64/az/lib/python3.6/site-packages/pip-21.0.1.dist-info.
You can also verify the issue no longer exists by installing the azure-devops extension and using az devops login.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

Thank you for your contribution finlaysawyer! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 2, 2021

@jiasli for awareness

@fengzhou-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@fengzhou-msft fengzhou-msft changed the title {Packaging} Upgrade pip version in bundled Python - RPM {Packaging} Upgrade pip version in RPM Mar 4, 2021
@fengzhou-msft
Copy link
Member

@finlaysawyer thanks for the PR. I tested it and it works fine. I changed the title as RPM package is not using a bundled python but the system python with CLI's own site-packages.

The below az script used by RPM (which az |xargs cat to see the content) sets a PYTHONPATH when running CLI commands and therefore pip under /usr/lib64/az/lib/python3.6/site-packages will be loaded instead of the one in system /usr/lib/python3.6/site-packages. If you simply run /usr/bin/python3 -m pip -V, you should still see an old version from /usr/lib/python3.6/site-packages.

#!/usr/bin/env bash
AZ_INSTALLER=RPM PYTHONPATH=/usr/lib64/az/lib/python3.6/site-packages /usr/bin/python3 -sm azure.cli "$@"

@fengzhou-msft fengzhou-msft merged commit 971c697 into Azure:dev Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Packaging/Pip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants