{Packaging} Remove azure-devtools as a dependency #15508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MSI package building failed in CI caused by building the latest
yarl
andmultidict
packages from source. Details in below comment.These 2 packages are implicitly downloaded as they are in the dependency tree of
azure-devtools
.azure-devtools
is only needed for development and testing and should be removed as a dependency inrequirements.txt
for buildingazure-cli
packages. Thesetup.py
forazure-cli
does not containazure-devtools
.yarl
is used instorage-blob-preview
, but the code has workaround whenyarl
is not available. So it's OK to remove it. Besides, if users install throughpip install azure-cli
,yarl
is not installed either and we haven't received relative issues.Testing Guide
Packages tested in
build_test
branch: https://dev.azure.com/azure-sdk/public/_build/results?buildId=573646&view=resultsHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.