Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] add ACR for azurestack hybrid profile #13442

Merged
merged 2 commits into from
May 13, 2020

Conversation

hhz1992
Copy link

@hhz1992 hhz1992 commented May 11, 2020

Description
Add Azure Container Registry (ACR) to Azure Stack profile given ACR will be in private preview in July 2020.

Testing Guide

  1. Switch to Azure Stack Cloud
  2. Use ACR command to tests

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@hhz1992 hhz1992 changed the title [AzureStack][ACR]add acr for azurestack [AzureStack][ACR]Add ACR for azurestack hybrid profile May 11, 2020
@yugangw-msft yugangw-msft changed the title [AzureStack][ACR]Add ACR for azurestack hybrid profile [ACR] add ACR for azurestack hybrid profile May 11, 2020
@yugangw-msft yugangw-msft added this to the S169 - For Build milestone May 11, 2020
@jiasli
Copy link
Member

jiasli commented May 12, 2020

@haroldrandom, we are still seeing this error:

https://github.com/Azure/azure-cli/pull/13442/checks?check_run_id=665133658

A task is missing. The pipeline references a task called 'ms-codeanalysis.vss-microsoft-security-code-analysis.build-task-credscan.CredScan'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 2, job 'CredScan', step ''.)
A task is missing. The pipeline references a task called 'ms-codeanalysis.vss-microsoft-security-code-analysis.build-task-postanalysis.PostAnalysis'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 1, job 'CredScan', step ''.)

Shouldn't the CI be run on the merge commit?

https://dev.azure.com/azure-sdk/public/_build/results?buildId=388471&view=logs&j=771f6cdf-8d98-5d9b-2fb9-d3a6e9554788&t=f1cfc14f-d466-5016-5ae3-5c9f81efa26d&l=20

git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules origin +refs/heads/*:refs/remotes/origin/* +refs/pull/13442/merge:refs/remotes/pull/13442/merge
git checkout --progress --force refs/remotes/pull/13442/merge

Update: I see. Because the target branch is not dev, but Azure:azurestack-aks. @hhz1992 shouldn't this PR target dev?

@haroldrandom
Copy link
Contributor

@haroldrandom, we are still seeing this error:

https://github.com/Azure/azure-cli/pull/13442/checks?check_run_id=665133658

A task is missing. The pipeline references a task called 'ms-codeanalysis.vss-microsoft-security-code-analysis.build-task-credscan.CredScan'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 2, job 'CredScan', step ''.)
A task is missing. The pipeline references a task called 'ms-codeanalysis.vss-microsoft-security-code-analysis.build-task-postanalysis.PostAnalysis'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 1, job 'CredScan', step ''.)

Shouldn't the CI be run on the merge commit?

https://dev.azure.com/azure-sdk/public/_build/results?buildId=388471&view=logs&j=771f6cdf-8d98-5d9b-2fb9-d3a6e9554788&t=f1cfc14f-d466-5016-5ae3-5c9f81efa26d&l=20

git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules origin +refs/heads/*:refs/remotes/origin/* +refs/pull/13442/merge:refs/remotes/pull/13442/merge
git checkout --progress --force refs/remotes/pull/13442/merge

The target branch is not dev instead of an older branch with problemic without disable CredScan temporarily. CredScan job is buggy in ADO account azure-sdk. Azure/azure-cli-extensions#1666

@hhz1992 hhz1992 merged commit e364268 into Azure:azurestack-aks May 13, 2020
@ghost ghost added Container Registry az acr and removed ACR labels Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants