[RBAC] az ad sp credential reset: fix weak credential generation
#13357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add to S169 |
|
Please title the PR with meaningful description, like "[RBAC] az ad sp credential reset: fix weak credential generation", so that |
jiasli
reviewed
May 7, 2020
Comment on lines
1744
to
1759
| def _random_password(length): | ||
| import random | ||
| import string | ||
| random_source = string.ascii_letters + string.digits + string.punctuation | ||
| password = random.choice(string.ascii_lowercase) | ||
| password += random.choice(string.ascii_uppercase) | ||
| password += random.choice(string.digits) | ||
| password += random.choice(string.punctuation) | ||
|
|
||
| for i in range(length - 4): | ||
| password += random.choice(random_source) | ||
|
|
||
| password_list = list(password) | ||
| random.SystemRandom().shuffle(password_list) | ||
| password = ''.join(password_list) | ||
| return password |
There was a problem hiding this comment.
If the code is borrowed from somewhere else, it is a good practice to put the source link in the comment: https://pynative.com/python-generate-random-string/
qianwens
changed the title
az ad sp credential resetaz ad sp credential reset: fix weak credential generation
jiasli
approved these changes
May 7, 2020
|
@fengzhou-msft I think we have decided not to include backticks |
jiasli
reviewed
May 9, 2020
| password += random.choice(string.digits) | ||
| password += random.choice(string.punctuation) | ||
|
|
||
| for i in range(length - 4): # pylint: disable=unused-variable |
There was a problem hiding this comment.
Suggested change
| for i in range(length - 4): # pylint: disable=unused-variable | |
| for _ in range(length - 4): |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Password autogenerated by
az ad sp credential resetis a Guid which is not secure.Testing Guide
az ad sp credential reset -n test
Expected result: password should be a string with at least one special character
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.