Skip to content

Commit

Permalink
webapp: remove '--runtime-version' from 'az webapp auth update' (#6183)
Browse files Browse the repository at this point in the history
yugangw-msft authored Apr 23, 2018
1 parent 32cab89 commit 6fc6098
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/command_modules/azure-cli-appservice/HISTORY.rst
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ Release History
===============
0.1.32
++++++
* webapp: remove `--runtime-version` from `az webapp auth update` as it's not very public ready
* webapp: az webapp config set support for min_tls_version & https2.0

0.1.31
Original file line number Diff line number Diff line change
@@ -272,7 +272,7 @@ def get_auth_settings(cmd, resource_group_name, name, slot=None):

def update_auth_settings(cmd, resource_group_name, name, enabled=None, action=None, # pylint: disable=unused-argument
client_id=None, token_store_enabled=None, # pylint: disable=unused-argument
runtime_version=None, token_refresh_extension_hours=None, # pylint: disable=unused-argument
token_refresh_extension_hours=None, # pylint: disable=unused-argument
allowed_external_redirect_urls=None, client_secret=None, # pylint: disable=unused-argument
allowed_audiences=None, issuer=None, facebook_app_id=None, # pylint: disable=unused-argument
facebook_app_secret=None, facebook_oauth_scopes=None, # pylint: disable=unused-argument
Original file line number Diff line number Diff line change
@@ -770,7 +770,6 @@ def test_webapp_authentication(self, resource_group):
JMESPathCheck('defaultProvider', None),
JMESPathCheck('enabled', False),
JMESPathCheck('tokenStoreEnabled', None),
JMESPathCheck('runtimeVersion', None),
JMESPathCheck('allowedExternalRedirectUrls', None),
JMESPathCheck('tokenRefreshExtensionHours', None),
JMESPathCheck('clientId', None),
@@ -784,7 +783,7 @@ def test_webapp_authentication(self, resource_group):

# update and verify
result = self.cmd('webapp auth update -g {} -n {} --enabled true --action LoginWithFacebook '
'--token-store false --runtime-version v5.0 --token-refresh-extension-hours 7.2 '
'--token-store false --token-refresh-extension-hours 7.2 '
'--aad-client-id aad_client_id --aad-client-secret aad_secret '
'--aad-allowed-token-audiences https://audience1 --aad-token-issuer-url https://issuer_url '
'--facebook-app-id facebook_id --facebook-app-secret facebook_secret '
@@ -794,7 +793,6 @@ def test_webapp_authentication(self, resource_group):
JMESPathCheck('defaultProvider', 'Facebook'),
JMESPathCheck('enabled', True),
JMESPathCheck('tokenStoreEnabled', False),
JMESPathCheck('runtimeVersion', 'v5.0'),
JMESPathCheck('tokenRefreshExtensionHours', 7.2),
JMESPathCheck('clientId', 'aad_client_id'),
JMESPathCheck('clientSecret', 'aad_secret'),

0 comments on commit 6fc6098

Please sign in to comment.