Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{portal} Migrate to AAZ #8383

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

cxznmhdcxz
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Dec 23, 2024

❌Azure CLI Extensions Breaking Change Test
❌portal
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd portal dashboard import cmd portal dashboard import update parameter name: added property required=True please remove property required=True for parameter name of cmd portal dashboard import
⚠️ 1006 - ParaAdd portal dashboard create cmd portal dashboard create added parameter lenses
⚠️ 1006 - ParaAdd portal dashboard create cmd portal dashboard create added parameter metadata
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter input_path: added property aaz_type=string
⚠️ 1009 - ParaPropRemove portal dashboard create cmd portal dashboard create update parameter input_path: removed property required=True
⚠️ 1010 - ParaPropUpdate portal dashboard create cmd portal dashboard create update parameter input_path: updated property type from file_type to string
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter location: added property aaz_type=string
⚠️ 1010 - ParaPropUpdate portal dashboard create cmd portal dashboard create update parameter location: updated property type from custom_type to string
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter name: added property type=string
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate portal dashboard create cmd portal dashboard create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter tags: added property aaz_type=AAZDictArg
⚠️ 1008 - ParaPropAdd portal dashboard create cmd portal dashboard create update parameter tags: added property type=Dict<String,String>
⚠️ 1010 - ParaPropUpdate portal dashboard create cmd portal dashboard create update parameter tags: updated property nargs from * to +
⚠️ 1004 - CmdPropRemove portal dashboard delete cmd portal dashboard delete removed property confirmation
⚠️ 1008 - ParaPropAdd portal dashboard delete cmd portal dashboard delete update parameter name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard delete cmd portal dashboard delete update parameter name: added property id_part=name
⚠️ 1008 - ParaPropAdd portal dashboard delete cmd portal dashboard delete update parameter name: added property type=string
⚠️ 1008 - ParaPropAdd portal dashboard delete cmd portal dashboard delete update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard delete cmd portal dashboard delete update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate portal dashboard delete cmd portal dashboard delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1006 - ParaAdd portal dashboard import cmd portal dashboard import added parameter tags
⚠️ 1008 - ParaPropAdd portal dashboard import cmd portal dashboard import update parameter input_path: added property aaz_type=string
⚠️ 1009 - ParaPropRemove portal dashboard import cmd portal dashboard import update parameter input_path: removed property required=True
⚠️ 1010 - ParaPropUpdate portal dashboard import cmd portal dashboard import update parameter input_path: updated property type from file_type to string
⚠️ 1008 - ParaPropAdd portal dashboard import cmd portal dashboard import update parameter name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard import cmd portal dashboard import update parameter name: added property type=string
⚠️ 1008 - ParaPropAdd portal dashboard import cmd portal dashboard import update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard import cmd portal dashboard import update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate portal dashboard import cmd portal dashboard import update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1006 - ParaAdd portal dashboard list cmd portal dashboard list added parameter pagination_limit
⚠️ 1006 - ParaAdd portal dashboard list cmd portal dashboard list added parameter pagination_token
⚠️ 1008 - ParaPropAdd portal dashboard list cmd portal dashboard list update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard list cmd portal dashboard list update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate portal dashboard list cmd portal dashboard list update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd portal dashboard show cmd portal dashboard show update parameter name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard show cmd portal dashboard show update parameter name: added property id_part=name
⚠️ 1008 - ParaPropAdd portal dashboard show cmd portal dashboard show update parameter name: added property type=string
⚠️ 1008 - ParaPropAdd portal dashboard show cmd portal dashboard show update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard show cmd portal dashboard show update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate portal dashboard show cmd portal dashboard show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1006 - ParaAdd portal dashboard update cmd portal dashboard update added parameter generic_update_add
⚠️ 1006 - ParaAdd portal dashboard update cmd portal dashboard update added parameter generic_update_force_string
⚠️ 1006 - ParaAdd portal dashboard update cmd portal dashboard update added parameter generic_update_remove
⚠️ 1006 - ParaAdd portal dashboard update cmd portal dashboard update added parameter generic_update_set
⚠️ 1006 - ParaAdd portal dashboard update cmd portal dashboard update added parameter lenses
⚠️ 1006 - ParaAdd portal dashboard update cmd portal dashboard update added parameter metadata
⚠️ 1006 - ParaAdd portal dashboard update cmd portal dashboard update added parameter tags
⚠️ 1008 - ParaPropAdd portal dashboard update cmd portal dashboard update update parameter input_path: added property aaz_type=string
⚠️ 1009 - ParaPropRemove portal dashboard update cmd portal dashboard update update parameter input_path: removed property required=True
⚠️ 1010 - ParaPropUpdate portal dashboard update cmd portal dashboard update update parameter input_path: updated property type from file_type to string
⚠️ 1008 - ParaPropAdd portal dashboard update cmd portal dashboard update update parameter name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard update cmd portal dashboard update update parameter name: added property id_part=name
⚠️ 1008 - ParaPropAdd portal dashboard update cmd portal dashboard update update parameter name: added property type=string
⚠️ 1008 - ParaPropAdd portal dashboard update cmd portal dashboard update update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd portal dashboard update cmd portal dashboard update update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate portal dashboard update cmd portal dashboard update update parameter resource_group_name: updated property name from resource_group_name to resource_group

Copy link

Hi @cxznmhdcxz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 23, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Hi @cxznmhdcxz

Release Suggestions

Module: portal

  • Please log updates into to src/portal/HISTORY.rst
  • Update VERSION to 1.0.0b1 in src/portal/setup.py
  • Set azext.isPreview to true in azext_metadata.json for portal
  • Remove azext.isExperimental: true in azext_portal/azext_metadata.json

Notes

@yonzhan yonzhan requested review from jsntcy and kairu-ms December 23, 2024 14:44
@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review December 24, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants