Enable no-wait and test validation for DeploymentErrors and Provision… #8365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp connected-env certificate delete | cmd containerapp connected-env certificate delete added parameter no_wait |
||
| containerapp connected-env certificate upload | cmd containerapp connected-env certificate upload added parameter no_wait |
||
| containerapp connected-env dapr-component remove | cmd containerapp connected-env dapr-component remove added parameter no_wait |
||
| containerapp connected-env dapr-component set | cmd containerapp connected-env dapr-component set added parameter no_wait |
|
Hi @LaylaLiu-gmail, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: containerapp
Notes
|
LaylaLiu-gmail
force-pushed
the
user/layliu/PutAsyncNoWaitDeploymentErrors
branch
from
2375d02 to
8f5ca98
Compare
LaylaLiu-gmail
force-pushed
the
user/layliu/PutAsyncNoWaitDeploymentErrors
branch
from
8f5ca98 to
a1dc764
Compare
Juliehzl
reviewed
Dec 12, 2024
Juliehzl
reviewed
Dec 12, 2024
Juliehzl
reviewed
Dec 12, 2024
Juliehzl
reviewed
Dec 12, 2024
Juliehzl
reviewed
Dec 12, 2024
Greedygre
approved these changes
Dec 12, 2024
zhoxing-ms
approved these changes
Jan 7, 2025
ksayid
pushed a commit
to SethHollandsworth/azure-cli-extensions
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to enable no-wait for several commands in az container connected-env subgroups
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.