Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/etcriss/cdb tableapi aad suppport/cli role commands #8310

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

etcriss
Copy link

@etcriss etcriss commented Nov 22, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @etcriss,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Nov 22, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️cosmosdb-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd cosmosdb table role sub group cosmosdb table role added

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 22, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 22, 2024
@yonzhan yonzhan added this to the Backlog milestone Nov 23, 2024
@@ -16,7 +16,7 @@

# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.
VERSION = '1.1.0b1'
VERSION = '1.2.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable version after 1.1.0b1 is 1.1.0.

@AllyW AllyW added the stable release extension module as stable label Nov 26, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 15, 2025
Comment on lines +26 to +28
builtin_role_def_id_full = '/subscriptions/80be3961-0521-4a0a-8570-5cd5a4e2f98c/resourceGroups/cli_test_cosmosdb_table_role_assignmentu4ss2n535bbvhe2wmufck5yfhyziujp77gg4/providers/Microsoft.DocumentDB/databaseAccounts/clikznzrccyiwbv/tableRoleDefinitions/00000000-0000-0000-0000-000000000001'

builtin_role_def_id_full_update = '/subscriptions/80be3961-0521-4a0a-8570-5cd5a4e2f98c/resourceGroups/cli_test_cosmosdb_table_role_assignmentu4ss2n535bbvhe2wmufck5yfhyziujp77gg4/providers/Microsoft.DocumentDB/databaseAccounts/clikznzrccyiwbv/tableRoleDefinitions/00000000-0000-0000-0000-000000000002'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid use fixed resource? Is it possible to create a role definition within test?

@evelyn-ys
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. stable release extension module as stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants