Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift tools and initial changes for networkfabric 2024-02-15-preview APIs #8286

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

nafizhaider32
Copy link
Contributor

@nafizhaider32 nafizhaider32 commented Nov 14, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 14, 2024

❌Azure CLI Extensions Breaking Change Test
❌managednetworkfabric
rule cmd_name rule_message suggest_message
1002 - CmdRemove networkfabric interface update-admin-state cmd networkfabric interface update-admin-state removed please confirm cmd networkfabric interface update-admin-state removed
⚠️ 1006 - ParaAdd networkfabric acl list cmd networkfabric acl list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric acl list cmd networkfabric acl list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric controller list cmd networkfabric controller list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric controller list cmd networkfabric controller list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric device list cmd networkfabric device list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric device list cmd networkfabric device list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric externalnetwork list cmd networkfabric externalnetwork list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric externalnetwork list cmd networkfabric externalnetwork list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric fabric list cmd networkfabric fabric list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric fabric list cmd networkfabric fabric list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric interface list cmd networkfabric interface list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric interface list cmd networkfabric interface list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric internalnetwork list cmd networkfabric internalnetwork list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric internalnetwork list cmd networkfabric internalnetwork list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric internetgateway list cmd networkfabric internetgateway list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric internetgateway list cmd networkfabric internetgateway list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric internetgatewayrule list cmd networkfabric internetgatewayrule list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric internetgatewayrule list cmd networkfabric internetgatewayrule list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric ipcommunity list cmd networkfabric ipcommunity list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric ipcommunity list cmd networkfabric ipcommunity list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric ipextendedcommunity list cmd networkfabric ipextendedcommunity list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric ipextendedcommunity list cmd networkfabric ipextendedcommunity list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric ipprefix list cmd networkfabric ipprefix list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric ipprefix list cmd networkfabric ipprefix list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric l2domain list cmd networkfabric l2domain list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric l2domain list cmd networkfabric l2domain list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric l3domain list cmd networkfabric l3domain list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric l3domain list cmd networkfabric l3domain list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric neighborgroup list cmd networkfabric neighborgroup list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric neighborgroup list cmd networkfabric neighborgroup list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric nni list cmd networkfabric nni list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric nni list cmd networkfabric nni list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric npb list cmd networkfabric npb list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric npb list cmd networkfabric npb list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric rack list cmd networkfabric rack list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric rack list cmd networkfabric rack list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric routepolicy list cmd networkfabric routepolicy list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric routepolicy list cmd networkfabric routepolicy list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric tap list cmd networkfabric tap list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric tap list cmd networkfabric tap list added parameter pagination_token
⚠️ 1006 - ParaAdd networkfabric taprule list cmd networkfabric taprule list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkfabric taprule list cmd networkfabric taprule list added parameter pagination_token

Copy link

Hi @nafizhaider32,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @nafizhaider32,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 14, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Nov 14, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 14, 2024
@yonzhan yonzhan requested a review from kairu-ms November 14, 2024 23:13
@yonzhan yonzhan requested a review from jsntcy November 14, 2024 23:14
@nafizhaider32 nafizhaider32 changed the title Uplift tools and initial changes for api version 2024-02-15-preview #626 Uplift tools and initial changes for networkfabric 2024-02-15-preview APIs Nov 15, 2024
@nafizhaider32 nafizhaider32 marked this pull request as draft November 15, 2024 16:44
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 18, 2024
@nafizhaider32 nafizhaider32 marked this pull request as ready for review November 18, 2024 16:30
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2024

Please fix CI issues

@nafizhaider32
Copy link
Contributor Author

nafizhaider32 commented Nov 18, 2024

Linked to Azure/aaz#626

@nafizhaider32
Copy link
Contributor Author

Please fix CI issues

CI Issues fixed and checked off guideline items

@necusjz
Copy link
Member

necusjz commented Nov 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Nov 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit 7e4fd96 into Azure:main Nov 26, 2024
21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ managednetworkfabric ] : https://dev.azure.com/msazure/One/_build/results?buildId=109029623&view=results

ksayid pushed a commit to SethHollandsworth/azure-cli-extensions that referenced this pull request Jan 8, 2025
… APIs (Azure#8286)

* updated network fabric extension to reflect version 2024-02-15-preview

* updates based on code review

* version updated to 7.0.0

* fix linting

---------

Co-authored-by: nafizhaider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants