-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft - Do not merge] [Quantum] Use Post Storage URI and SAS token like Quantum Python SDK (27643) #8242
Draft
warren-jones
wants to merge
29
commits into
Azure:main
Choose a base branch
from
warren-jones:27643-use-post-storage-uri-and-sas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Draft - Do not merge] [Quantum] Use Post Storage URI and SAS token like Quantum Python SDK (27643) #8242
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
e3c8054
Temporarily append '.dev3' to version number
warren-jones d818972
Calling upload-blob with return_sas_token = True
warren-jones b6fa1db
Incorporated azure-quantum-python functions
warren-jones 1ca2709
Adding a SAS token to the storage container URL
warren-jones 2bdf773
Moved an import statement from _storage.py to job.py
warren-jones 1d06fd9
Fixed style check violations
warren-jones 1983073
Deleted an extraneous comment
warren-jones 7bb57e3
Added a unit test
warren-jones 1a105cc
Expanded the unit test
warren-jones 042064b
Made changes to test_submit
warren-jones 703f3e9
Made changes to test_submit
warren-jones b4ef46d
Updated test_provider_sku_list
warren-jones 950a4e0
Added experimental Python SDK code to run a Qiskit input file
warren-jones dc940c1
Added test input files and simplified the job submit code
warren-jones 50cee37
Rearranged the submit code to use old param validation
warren-jones b85a23f
Got it working with imported Python SDK methods
warren-jones 5d71981
Un-did changes to _storage.py and _client_factory.py
warren-jones 941ef50
Fixed Pylint rule violations
warren-jones 9101d4e
Experimenting with ways to suppress the expected azure.identity Crede…
warren-jones be59ec2
Deleted unused import statements
warren-jones 3733adc
Copied azure-quantum-python files to the CLI repo
warren-jones a282256
Added missing SDK files and fixed another import
warren-jones c00aa7c
Added the azure.identity files to vendored_sdks
warren-jones 1ef8c76
Fixed another azure.identity import
warren-jones 40af901
Deleted a commented-out line
warren-jones 3fc5f02
Moved the azure-quantum-python files to the vendored_sdks folder
warren-jones 31cca14
Deleted commented-out lines
warren-jones 5556f1b
Removed 'microsoft.qc' from the default test provider/SKU list and re…
warren-jones 0ad93b0
Made test changes like in branch 29126-remove-resource-estimator-refe…
warren-jones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
src/quantum/azext_quantum/vendored_sdks/azure_identity/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# ------------------------------------ | ||
# Copyright (c) Microsoft Corporation. | ||
# Licensed under the MIT License. | ||
# ------------------------------------ | ||
"""Credentials for Azure SDK clients.""" | ||
|
||
from ._auth_record import AuthenticationRecord | ||
from ._exceptions import AuthenticationRequiredError, CredentialUnavailableError | ||
from ._constants import AzureAuthorityHosts, KnownAuthorities | ||
from ._credentials import ( | ||
AuthorizationCodeCredential, | ||
AzureDeveloperCliCredential, | ||
AzureCliCredential, | ||
AzurePowerShellCredential, | ||
CertificateCredential, | ||
ChainedTokenCredential, | ||
ClientAssertionCredential, | ||
ClientSecretCredential, | ||
DefaultAzureCredential, | ||
DeviceCodeCredential, | ||
EnvironmentCredential, | ||
InteractiveBrowserCredential, | ||
ManagedIdentityCredential, | ||
OnBehalfOfCredential, | ||
SharedTokenCacheCredential, | ||
UsernamePasswordCredential, | ||
VisualStudioCodeCredential, | ||
WorkloadIdentityCredential, | ||
AzurePipelinesCredential, | ||
) | ||
from ._persistent_cache import TokenCachePersistenceOptions | ||
from ._bearer_token_provider import get_bearer_token_provider | ||
|
||
|
||
__all__ = [ | ||
"AuthenticationRecord", | ||
"AuthenticationRequiredError", | ||
"AuthorizationCodeCredential", | ||
"AzureAuthorityHosts", | ||
"AzureCliCredential", | ||
"AzureDeveloperCliCredential", | ||
"AzurePipelinesCredential", | ||
"AzurePowerShellCredential", | ||
"CertificateCredential", | ||
"ChainedTokenCredential", | ||
"ClientAssertionCredential", | ||
"ClientSecretCredential", | ||
"CredentialUnavailableError", | ||
"DefaultAzureCredential", | ||
"DeviceCodeCredential", | ||
"EnvironmentCredential", | ||
"InteractiveBrowserCredential", | ||
"KnownAuthorities", | ||
"OnBehalfOfCredential", | ||
"ManagedIdentityCredential", | ||
"SharedTokenCacheCredential", | ||
"TokenCachePersistenceOptions", | ||
"UsernamePasswordCredential", | ||
"VisualStudioCodeCredential", | ||
"WorkloadIdentityCredential", | ||
"get_bearer_token_provider", | ||
] | ||
|
||
from ._version import VERSION | ||
|
||
__version__ = VERSION |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anything here create an actual container from the containerUri? Previously, it looks like create_container would do this.
We need to create a container if it doesn't already exists. The service just returns a URI, it doesn't actually create it today., although we are planning to modify it so that it creates it. The cli should handle both cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like upload_blob will create a container if it doesn't already exist, so I think we are good.