Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confcom] adding fragment support #8238

Merged
merged 17 commits into from
Nov 8, 2024
Merged

Conversation

SethHollandsworth
Copy link
Contributor

Adding support for image-attached fragments. Also, bugfixes for VN2, using _validators.py, and overwrite logic for vn2 policies

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 5, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️confcom
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd confcom acifragmentgen cmd confcom acifragmentgen added
⚠️ 1006 - ParaAdd confcom acipolicygen cmd confcom acipolicygen added parameter exclude_default_fragments
⚠️ 1006 - ParaAdd confcom acipolicygen cmd confcom acipolicygen added parameter fragments_json
⚠️ 1006 - ParaAdd confcom acipolicygen cmd confcom acipolicygen added parameter include_fragments
⚠️ 1006 - ParaAdd confcom acipolicygen cmd confcom acipolicygen added parameter omit_id

Copy link

Hi @SethHollandsworth,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 5, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 5, 2024

@kairu-ms
Copy link
Contributor

kairu-ms commented Nov 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit 7d4644e into Azure:main Nov 8, 2024
21 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 8, 2024

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/release/_build/results?buildId=204793&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants