-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Doc} Update domain after Microsoft Docs rebranding to Microsoft Learn #8179
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @xmdanni, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Hi @xmdanni Release SuggestionsModule: alertsmanagement
Module: aosm
Module: automation
Module: azurelargeinstance
Module: connectedk8s
Module: costmanagement
Module: dataprotection
Module: desktopvirtualization
Module: front-door
Module: hdinsightonaks
Module: k8s-configuration
Module: k8s-extension
Module: load
Module: log-analytics-solution
Module: logic
Module: mesh
Module: offazure
Module: portal
Module: quota
Module: serviceconnector-passwordless
Module: spring
Module: spring-cloud
Module: ssh
Module: storagesync
Module: virtual-wan
Module: vm-repair
Module: vmware
Module: workloads
Notes
|
@@ -1032,7 +1032,7 @@ async def get_available_agent_pool_versions( | |||
"""Gets a list of supported Kubernetes versions for the specified agent pool. | |||
|
|||
See `supported Kubernetes versions | |||
<https://docs.microsoft.com/azure/aks/supported-kubernetes-versions>`_ for more details about | |||
<https://learn.microsoft.com/azure/aks/supported-kubernetes-versions>`_ for more details about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content under path vendored_sdks
is generated based on swagger. I think you'll need to change the content of source, otherwise these changes will be overwritten when the new SDK is generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Where is the source content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xmdanni the files under vendored_sdk_xxx folder are auto generated from https://github.com/Azure/azure-rest-api-specs/tree/main/specification, which also needs a batch domain update for microsoft.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f69f740
to
887e1e3
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
aaz models used in code under |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
src/index.json
Outdated
@@ -18060,7 +18060,7 @@ | |||
"description": "DESCRIPTION.rst" | |||
}, | |||
"project_urls": { | |||
"Home": "https://docs.microsoft.com/en-us/azure/azure-arc/data/" | |||
"Home": "https://learn.microsoft.com/en-us/azure/azure-arc/data/" | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please split change to module and index.json into different prs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, thanks!
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Modules below are excluded for outdated tests and styling check failure and need to be copied with in the future (plan to add into cli linter rule to mitigate in daily prs).
|
Microsoft Docs has been rebranded to Microsoft Learn for a long time, outdated links can have a negative impact on the output of the generative AI for Knowledge Service. So, links on reference pages need to use our new domain.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.