[k8s-extension] Update extension CLI to v1.4.3 #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First draft for Data Protection K8s backup extension (Pending internal review) * Removing tracing * Minor changes to improve azdev style * Internal PR review feedback Co-authored-by: Rishabh Raj <[email protected]>
…ad of workspace (#175) * fix: Update DCR creation to Clusters resource group instead of workspace * . * . * casing check
adding the api version to the operation definition in the client factory
bump k8s-extension version to 1.3.6
…n expected by the service
…tests adding tests for all 4 extension types calls
…into release-1.3.6
…tensiontypetests adding upstream test for extension types
…into release-1.3.6
…into release-1.3.6
…eate (#188) * Add more validations and user prompt for existing installation scenario Signed-off-by: Shubham Sharma <[email protected]> * Add Dapr test' Signed-off-by: Shubham Sharma <[email protected]> * Handle stateful set Signed-off-by: Shubham Sharma <[email protected]> * Update default handling Signed-off-by: Shubham Sharma <[email protected]> * Fix HA handling Signed-off-by: Shubham Sharma <[email protected]> * Add placement service todo Signed-off-by: Shubham Sharma <[email protected]> * Add non-interactive mode Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Update tests Signed-off-by: Shubham Sharma <[email protected]> * Reset configuration for StatefulSet during k8s upgrade Signed-off-by: Shubham Sharma <[email protected]> * Fix lint Signed-off-by: Shubham Sharma <[email protected]> * Retrigger tests Signed-off-by: Shubham Sharma <[email protected]> * Add changes to manage ha and placement params Signed-off-by: Shubham Sharma <[email protected]> * Update message Signed-off-by: Shubham Sharma <[email protected]> * nits Signed-off-by: Shubham Sharma <[email protected]> Signed-off-by: Shubham Sharma <[email protected]>
bump k8s-extension version to 1.4.3
Signed-off-by: nshankar <[email protected]> Co-authored-by: nshankar <[email protected]>
…eview Add support for extensionsType api
[second iteration] bump k8s-extension version to 1.4.3 - including additional changes
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @bavneetsingh16, |
|
k8s-extension |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms and
wangzelin007
Please be do not release breaking changes in the non breaking change Sprint. Please deprecate and hide them first. For more details about the breaking process, please refer to this doc breaking change process |
|
May I ask why you closed the original PR #6575 and opened this new PR? What are the differences between them? |
Since the original pr was not yet merged, we had some additional changes that needed to be released. The pr links for the new changes are:
|
Add old commands back with deprecated status
zhoxing-ms
reviewed
Aug 15, 2023
Comment on lines
+117
to
+128
| c.argument('plan_name', | ||
| arg_group="Marketplace", | ||
| options_list=['--plan-name'], | ||
| help='The plan name is referring to the Marketplace Plan ID of the extension.') | ||
| c.argument('plan_product', | ||
| arg_group="Marketplace", | ||
| options_list=['--plan-product'], | ||
| help='The plan product is referring to the Marketplace Product ID of the extension.') | ||
| c.argument('plan_publisher', | ||
| arg_group="Marketplace", | ||
| options_list=['--plan-publisher'], | ||
| help='The plan publisher is referring to the Marketplace Publisher ID of the extension') |
There was a problem hiding this comment.
Please do not explicitly declare the default option name
Suggested change
| c.argument('plan_name', | |
| arg_group="Marketplace", | |
| options_list=['--plan-name'], | |
| help='The plan name is referring to the Marketplace Plan ID of the extension.') | |
| c.argument('plan_product', | |
| arg_group="Marketplace", | |
| options_list=['--plan-product'], | |
| help='The plan product is referring to the Marketplace Product ID of the extension.') | |
| c.argument('plan_publisher', | |
| arg_group="Marketplace", | |
| options_list=['--plan-publisher'], | |
| help='The plan publisher is referring to the Marketplace Publisher ID of the extension') | |
| c.argument('plan_name', | |
| arg_group="Marketplace", | |
| help='The plan name is referring to the Marketplace Plan ID of the extension.') | |
| c.argument('plan_product', | |
| arg_group="Marketplace", | |
| help='The plan product is referring to the Marketplace Product ID of the extension.') | |
| c.argument('plan_publisher', | |
| arg_group="Marketplace", | |
| help='The plan publisher is referring to the Marketplace Publisher ID of the extension') |
zhoxing-ms
reviewed
Aug 15, 2023
| @@ -33,7 +33,7 @@ | |||
| # TODO: Add any additional SDK dependencies here | |||
| DEPENDENCIES = [] | |||
|
|
|||
| VERSION = "1.4.2" | |||
| VERSION = "1.4.3" | |||
There was a problem hiding this comment.
Suggested change
| VERSION = "1.4.3" | |
| VERSION = "2.0.0" |
Since this PR includes breaking changes, we usually recommend upgrading the major version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.