Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic-SAN] BREAKING CHANGE az elastic-san: Support private endpoint, remove --tags from volume-group and volume #6548

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

calvinhzy
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Support 2022-12-01-preview regen and rerun tests, --tags were removed by volume and volume-group

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Jul 24, 2023
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 24, 2023

❌Azure CLI Extensions Breaking Change Test
❌elastic-san
rule cmd_name rule_message suggest_message
1009 - ParaPropRemove elastic-san create cmd elastic-san create update parameter elastic_san_name: removed property id_part please add back property id_part for parameter elastic_san_namefor cmdelastic-san create`
1007 - ParaRemove elastic-san volume create cmd elastic-san volume create removed parameter tags please add back parameter tags for cmd elastic-san volume create
1009 - ParaPropRemove elastic-san volume create cmd elastic-san volume create update parameter elastic_san_name: removed property id_part please add back property id_part for parameter elastic_san_namefor cmdelastic-san volume create`
1008 - ParaPropAdd elastic-san volume create cmd elastic-san volume create update parameter size_gib: added property required please remove property required for parameter size_gib for cmd elastic-san volume create
1009 - ParaPropRemove elastic-san volume create cmd elastic-san volume create update parameter volume_group_name: removed property id_part please add back property id_part for parameter volume_group_namefor cmdelastic-san volume create`
1009 - ParaPropRemove elastic-san volume create cmd elastic-san volume create update parameter volume_name: removed property id_part please add back property id_part for parameter volume_namefor cmdelastic-san volume create`
1007 - ParaRemove elastic-san volume update cmd elastic-san volume update removed parameter tags please add back parameter tags for cmd elastic-san volume update
1007 - ParaRemove elastic-san volume-group create cmd elastic-san volume-group create removed parameter tags please add back parameter tags for cmd elastic-san volume-group create
1009 - ParaPropRemove elastic-san volume-group create cmd elastic-san volume-group create update parameter elastic_san_name: removed property id_part please add back property id_part for parameter elastic_san_namefor cmdelastic-san volume-group create`
1009 - ParaPropRemove elastic-san volume-group create cmd elastic-san volume-group create update parameter volume_group_name: removed property id_part please add back property id_part for parameter volume_group_namefor cmdelastic-san volume-group create`
1007 - ParaRemove elastic-san volume-group update cmd elastic-san volume-group update removed parameter tags please add back parameter tags for cmd elastic-san volume-group update
⚠️ 1006 - ParaAdd elastic-san list cmd elastic-san list added parameter pagination_limit
⚠️ 1006 - ParaAdd elastic-san list cmd elastic-san list added parameter pagination_token
⚠️ 1006 - ParaAdd elastic-san volume list cmd elastic-san volume list added parameter pagination_limit
⚠️ 1006 - ParaAdd elastic-san volume list cmd elastic-san volume list added parameter pagination_token
⚠️ 1006 - ParaAdd elastic-san volume-group list cmd elastic-san volume-group list added parameter pagination_limit
⚠️ 1006 - ParaAdd elastic-san volume-group list cmd elastic-san volume-group list added parameter pagination_token

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 24, 2023

Elastic-SAN

@yonzhan yonzhan requested review from jsntcy and necusjz July 24, 2023 11:12
@calvinhzy calvinhzy marked this pull request as ready for review July 25, 2023 04:52
@calvinhzy calvinhzy changed the title [Elastic-SAN] Support private endpoint [Elastic-SAN] BREAK CHANGE az elastic-san: Support private endpoint Jul 25, 2023
@calvinhzy calvinhzy changed the title [Elastic-SAN] BREAK CHANGE az elastic-san: Support private endpoint [Elastic-SAN] BREAKING CHANGE az elastic-san: Support private endpoint, remove tags from volume-group and volume Jul 25, 2023
@calvinhzy calvinhzy changed the title [Elastic-SAN] BREAKING CHANGE az elastic-san: Support private endpoint, remove tags from volume-group and volume [Elastic-SAN] BREAKING CHANGE az elastic-san: Support private endpoint, remove --tags from volume-group and volume Jul 25, 2023
@necusjz
Copy link
Member

necusjz commented Jul 25, 2023

@jsntcy If I remember correctly, breaking-change release needs to update major version, right?

@calvinhzy calvinhzy merged commit c6b63cc into Azure:main Jul 25, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ elastic-san ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=75655&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants