-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connectedmachine] release stable version 2022-12-27 #6522
Conversation
Feature extensionimage
❌Azure CLI Extensions Breaking Change Test
|
Hi @yaotongms, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
Thank you for your contribution yaotongms! We will review the pull request and get back to you soon. |
the corresponding aaz PR: Azure/aaz#227 |
@microsoft-github-policy-service agree company="Microsoft" |
self.cmd('az connectedmachine install-patches ' | ||
'--resource-group "{rg}" ' | ||
'--name "{machine}" ' | ||
'--maximum-duration "PT4H" ' | ||
'--reboot-setting "IfRequired" ' | ||
'--windows-parameters "{{\\"classificationsToInclude\\":[\\"Critical\\", \\"Security\\"]}}"', | ||
checks=[ | ||
self.check('properties.resourceGroup', '{rg}'), | ||
self.check('properties.name', '{machine}'), | ||
self.check('properties.maximumDuration', 'PT4H'), | ||
self.check('properties.rebootSetting', 'IfRequired') | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except CannotOverwriteExistingCassetteException as ex:
raise AssertionError(ex)
E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/connectedmachine/azext_connectedmachine/tests/latest/recordings/test_machine_and_extension.yaml') in your current record mode ('once').
E No match for the request (<Request (POST) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/installPatches?api-version=2022-12-27>) was found.
E Found 1 similar requests with 1 different matcher(s) :
E
E 1 - (<Request (POST) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/upgradeExtensions?api-version=2022-12-27>)..)
E Matchers succeeded : ['method', 'scheme', 'host', 'port', '_custom_request_query_matcher']
E Matchers failed :
E path - assertion failure :
E /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/installPatches != /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/upgradeExtensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yaml file of test_machine_and_extension
did not record the https://management.azure.com/subscriptions/xxx/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/installPatches
request for the az connectedmachine install-patches
command. Please check if the REST call in the az connectedmachine install-patches
command was triggered when recording the yaml file in your local environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except CannotOverwriteExistingCassetteException as ex:
raise AssertionError(ex)
E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/connectedmachine/azext_connectedmachine/tests/latest/recordings/test_machine_and_extension.yaml') in your current record mode ('once').
E No match for the request (<Request (POST) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/installPatches?api-version=2022-12-27>) was found.
E Found 1 similar requests with 1 different matcher(s) :
E
E 1 - (<Request (POST) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/upgradeExtensions?api-version=2022-12-27>)..)
E Matchers succeeded : ['method', 'scheme', 'host', 'port', '_custom_request_query_matcher']
E Matchers failed :
E path - assertion failure :
E /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/installPatches != /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/az-sdk-test/providers/Microsoft.HybridCompute/machines/testmachine/upgradeExtensions
added on the latest commit
Please resolve the Static Analysis issues and CLI Linter issues |
fixed in the latest commit |
fixed in the latest push |
could you please add some description messages for this PR in #6522 (comment)? |
description added at the top |
Co-authored-by: Yan Zhu <[email protected]>
src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/_delete.py
Outdated
Show resolved
Hide resolved
src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/_delete.py
Outdated
Show resolved
Hide resolved
src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/_list.py
Outdated
Show resolved
Hide resolved
src/connectedmachine/azext_connectedmachine/aaz/latest/connectedmachine/extension/_show.py
Outdated
Show resolved
Hide resolved
…edmachine/_delete.py Co-authored-by: Yan Zhu <[email protected]>
…edmachine/extension/_show.py Co-authored-by: Yan Zhu <[email protected]>
…edmachine/extension/_delete.py Co-authored-by: Yan Zhu <[email protected]>
…edmachine/extension/_list.py Co-authored-by: Yan Zhu <[email protected]>
Please verify if there is any breaking change in this PR. |
The breaking changes include changing in parameter names and removing commands that users won't be able to use (calling internal apis). This release should not contain any breaking change. |
@@ -10,7 +10,7 @@ | |||
from setuptools import setup, find_packages | |||
|
|||
# HISTORY.rst entry. | |||
VERSION = '0.5.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, we only recommend upgrading to the major version when there is a breaking change. If this PR does not include the breaking change, could we only upgrade to the secondary version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated version number to 0.6.0
Co-authored-by: Xing Zhou <[email protected]>
[Release] Update index.json for extension [ connectedmachine ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=82015&view=results |
This release is targeting version 2022-12-27 of connectedmachine and using aaz. You will see all commands from the previous version with the following new commands:
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.