[confcom] changing version number naming scheme and bugfix for 32bit python #6144

SethHollandsworth · 2023-03-29T17:43:06Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

azure-client-tools-bot-prd · 2023-03-29T17:43:10Z

Hi @SethHollandsworth,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan · 2023-03-29T17:43:19Z

confcom

matajoh

There seems to still be a bit of confusion here about SVN vs version. Might be good to clarify variables names etc. to make it clearer.

src/confcom/samples/sample-policy-output.rego

src/confcom/azext_confcom/config.py

src/confcom/.gitignore

src/confcom/setup.py

…into arm template

Feature/sha256 hash, removing --json flag

…rs for template parameters

adding warnings for save to file and debug mode.

…in the arm template

making it so you can disable allow_elevated via the privileged field …

* securityContext --------- Co-authored-by: Seth Hollandsworth <[email protected]> Co-authored-by: Seth Hollandsworth <[email protected]>

…privileges changing default value of no_new_privileges

taking allow_elevated out of expected fields in ARM template

adding docs for dmverity hashing and fixing markdown styling

src/confcom/azext_confcom/custom.py

src/confcom/azext_confcom/rootfs_proxy.py

src/confcom/setup.py

azclibot · 2023-05-08T22:04:35Z

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=53328&view=results

changing version number naming scheme and bugfix for 32bit python

69e7970

azure-client-tools-bot-prd bot added this to the April 2023 (2023-04-25) milestone Mar 29, 2023

SethHollandsworth marked this pull request as draft March 29, 2023 17:45

yonzhan requested review from kairu-ms and jsntcy March 30, 2023 00:22

yonzhan assigned kairu-ms Mar 30, 2023

matajoh suggested changes Mar 31, 2023

View reviewed changes

src/confcom/samples/sample-policy-output.rego Outdated Show resolved Hide resolved

src/confcom/azext_confcom/config.py Outdated Show resolved Hide resolved

src/confcom/.gitignore Outdated Show resolved Hide resolved

src/confcom/setup.py Outdated Show resolved Hide resolved

SethHollandsworth and others added 16 commits April 3, 2023 10:01

addressing PR comments

7b0e904

moving where pulling files happens from

db1efe0

making a sha256 hash of the security policy print out when injecting …

0826d37

…into arm template

taking out the --json option

cdc3be4

removing unused function

9e841d5

Merge pull request #23 from SethHollandsworth/feature/sha256_hash

fd14dfc

Feature/sha256 hash, removing --json flag

adding warnings for save to file and debug mode. fixed bug with numbe…

1eb7f65

…rs for template parameters

Merge pull request #22 from SethHollandsworth/update_save_to_file

50be7ac

adding warnings for save to file and debug mode.

taking out unused function and fixing style checks

7217ed9

adding error checking back in for when dmverity-vhd returns nothing

1036a71

making it so you can disable allow_elevated via the privileged field …

d0fb0b7

…in the arm template

Merge pull request #20 from SethHollandsworth/feature/allow_elevated

34ddd1d

making it so you can disable allow_elevated via the privileged field …

Feature/security context (#18)

aff3a33

* securityContext --------- Co-authored-by: Seth Hollandsworth <[email protected]> Co-authored-by: Seth Hollandsworth <[email protected]>

changing default value of no_new_privileges

6ea9dfd

updating tests

220357d

Merge pull request #24 from SethHollandsworth/bugfix/changing_no_new_…

f8b0297

…privileges changing default value of no_new_privileges

SethHollandsworth marked this pull request as ready for review May 1, 2023 18:13

SethHollandsworth marked this pull request as draft May 3, 2023 19:57

SethHollandsworth and others added 2 commits May 3, 2023 16:13

taking allow_elevated out of expected fields in ARM template

2a72e5d

Merge pull request #25 from SethHollandsworth/bugfix/allow_elevated

7f2421b

taking allow_elevated out of expected fields in ARM template

yonzhan removed this from the April 2023 (2023-04-25) milestone May 4, 2023

yonzhan added this to the May 2023 (2023-05-23) - For Build milestone May 4, 2023

SethHollandsworth and others added 2 commits May 4, 2023 14:51

adding docs for dmverity hashing and fixing markdown styling

faf33ca

Merge pull request #26 from SethHollandsworth/dmverity_docs

834fba5

adding docs for dmverity hashing and fixing markdown styling

SethHollandsworth marked this pull request as ready for review May 4, 2023 19:35

kairu-ms reviewed May 5, 2023

View reviewed changes

src/confcom/azext_confcom/custom.py Show resolved Hide resolved

src/confcom/azext_confcom/rootfs_proxy.py Show resolved Hide resolved

src/confcom/setup.py Show resolved Hide resolved

kairu-ms approved these changes May 6, 2023

View reviewed changes

kairu-ms merged commit ead702f into Azure:main May 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[confcom] changing version number naming scheme and bugfix for 32bit python #6144

[confcom] changing version number naming scheme and bugfix for 32bit python #6144

SethHollandsworth commented Mar 29, 2023

azure-client-tools-bot-prd bot commented Mar 29, 2023

yonzhan commented Mar 29, 2023

matajoh left a comment

azclibot commented May 8, 2023

[confcom] changing version number naming scheme and bugfix for 32bit python #6144

[confcom] changing version number naming scheme and bugfix for 32bit python #6144

Conversation

SethHollandsworth commented Mar 29, 2023

Related command

General Guidelines

azure-client-tools-bot-prd bot commented Mar 29, 2023

yonzhan commented Mar 29, 2023

matajoh left a comment

Choose a reason for hiding this comment

azclibot commented May 8, 2023