updated patch behaviour for azureHybridBenefit property in connectedk8s #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested review from
|
connectedk8s |
sirireddy12
approved these changes
Nov 16, 2022
zhoxing-ms
reviewed
Nov 16, 2022
Comment on lines
+951
to
+954
| # Returning the ARM response if only AHB is being updated | ||
| arm_properties_only_ahb_set = (tags is None and distribution is None and distribution_version is None and azure_hybrid_benefit is not None) | ||
| if proxy_params_unset and auto_upgrade is None and container_log_path is None and arm_properties_only_ahb_set: | ||
| return patch_cc_response |
There was a problem hiding this comment.
Could you add a test case for this change?
There was a problem hiding this comment.
@zhoxing-ms , The test case for that is already covered in the test file. I have re-recorded the tests which should have covered this case
akashkeshari
requested review from
zhoxing-ms
and removed request for
jsntcy,
wangzelin007 and
yonzhan
zhoxing-ms
approved these changes
Nov 16, 2022
|
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=15283&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.