Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guitar/app acc #5534

Merged
merged 14 commits into from
Nov 22, 2022
Merged

Guitar/app acc #5534

merged 14 commits into from
Nov 22, 2022

Conversation

guitarsheng
Copy link
Contributor

@guitarsheng guitarsheng commented Nov 9, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 9, 2022

spring

src/spring/azext_spring/_help.py Outdated Show resolved Hide resolved
src/spring/azext_spring/_params.py Outdated Show resolved Hide resolved
src/spring/azext_spring/_tanzu_component.py Outdated Show resolved Hide resolved
src/spring/azext_spring/_tanzu_component.py Outdated Show resolved Hide resolved
src/spring/azext_spring/_transformers.py Show resolved Hide resolved
src/spring/azext_spring/commands.py Show resolved Hide resolved
src/spring/azext_spring/commands.py Show resolved Hide resolved
src/spring/azext_spring/commands.py Outdated Show resolved Hide resolved
src/spring/azext_spring/commands.py Outdated Show resolved Hide resolved
src/spring/azext_spring/_params.py Outdated Show resolved Hide resolved
@yuwzho
Copy link
Contributor

yuwzho commented Nov 17, 2022

#5532

# Conflicts:
#	src/spring/azext_spring/_help.py
#	src/spring/azext_spring/_params.py
#	src/spring/azext_spring/_tanzu_component.py
#	src/spring/azext_spring/_validators.py
#	src/spring/azext_spring/commands.py
@guitarsheng guitarsheng force-pushed the guitar/app-acc branch 4 times, most recently from f39129a to 882cf6e Compare November 18, 2022 19:25
@guitarsheng
Copy link
Contributor Author

hi @zhoxing-ms

All checks have passed. It's part of dev tools feature which is relevant to PR as shown in link below
#5522

Can you please help to review?

@zhoxing-ms zhoxing-ms merged commit 9403e36 into Azure:main Nov 22, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=16290&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants