Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{rdbms-connect} Update mycli to 1.26.1 and pgcli to 3.4.1 #5476

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

alanenriqueo
Copy link
Member

@alanenriqueo alanenriqueo commented Oct 21, 2022

  • When trying to connect to a mysql server using az mysql flexible-server connect --interactive, we get an error message saying module 'click' has no attribute 'get_terminal_size', this is fixed in mycli==1.26.1. This version change requires explicitely to set autocommit=true for executing queries.
  • When trying to connect to a postgres server using az postgres flexible-server connect --interactive in Windows 32-bit we could get an error message saying ImportError: no pq wrapper available if we don't have library libpq.dll installed, that is because current pgcli==3.0.0 depends on pgspecial>=1.11.8 which in turns depends on psycopg 3, which is only compatible for 64-bit. So, we need to use specific version pgcli==3.4.1 which depends on exactly pgspecial=1.13.1 which in turn depends on psycopg2, and that is compatible for 32-bit also since it's older. az postgres flexible-server connect failing azure-cli#22889

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 21, 2022

rdbms-connect

@evelyn-ys evelyn-ys merged commit 32171db into Azure:main Oct 24, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ rdbms-connect ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=10641&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants