-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Software Assurance support on connected clusters for AKS HCI #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned zhoxing-ms
Oct 14, 2022
ghost
added this to the Oct 2022 (2022-11-01) milestone
Oct 14, 2022
ghost
requested a review
from yonzhan
October 14, 2022 09:05
ghost
added
the
AKS
label
Oct 14, 2022
Adding tests for new features is still pending |
connectedk8s |
sirireddy12
reviewed
Oct 17, 2022
Tests added & re-recorded |
adkanetk
approved these changes
Oct 19, 2022
KarthikK123
reviewed
Oct 19, 2022
sirireddy12
approved these changes
Oct 19, 2022
zhoxing-ms
reviewed
Oct 19, 2022
akashkeshari
requested review from
zhoxing-ms
and removed request for
wangzelin007 and
yonzhan
October 19, 2022 14:23
zhoxing-ms
approved these changes
Oct 20, 2022
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=10119&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.