-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ssh] Add support to "Microsoft.ConnectedVMwarevSphere/virtualMachines" resource type #5367
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d9719ed
Remove RP calls to check resource type. Only make one call to azure r…
vthiebaut10 1f00456
Refactor code to facilitate adding support to new types, and added su…
vthiebaut10 798b3a1
Correct parameter help
vthiebaut10 7657051
Fix style errors
vthiebaut10 a1f625b
fix tests
vthiebaut10 649ce2c
Remove hard-coded resource type from hybridconnectivity sdk
vthiebaut10 4136c64
fix az ssh arc command
vthiebaut10 2745cb6
small changes?
vthiebaut10 8a2208e
Fix test
vthiebaut10 c4df9c2
Fix errors on aio for connectedvmware caused by the changes I made to…
vthiebaut10 531fac4
Add support to Microsoft.ScVmm/virtualMachines and Microsoft.AzureSta…
vthiebaut10 8756044
Fix style error
vthiebaut10 1c9fc0d
Create customResourceType for vmware client
vthiebaut10 84c3096
Remove CustomResourceType for vmware client
vthiebaut10 bc44dbc
Merge remote-tracking branch 'upstream/main' into private_clouds
vthiebaut10 2ad695f
Fix comments, style, and history
vthiebaut10 380e4ba
fix merge conflicts
vthiebaut10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please define a
CustomResourceType
forAzureArcVMwareManagementServiceAPI
, such as:azure-cli-extensions/src/storage-preview/azext_storage_preview/profiles.py
Lines 11 to 12 in 7962586
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms Why do we need to use this custom resource type? do I need to use it for the other clients in the same file as well? (hybrid connectivity and connected machine clients)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms when I try to use that I get this error:
azure.cli.core.profiles._shared.APIVersionException: Unable to get API version for type '<azure.cli.core.profiles._shared.CustomResourceType object at 0x00000267F5ADE250>' in profile 'latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms I pushed the changes you requested, but this error still happens. Do you know what might cause that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vthiebaut10 I recommended you define
CustomResourceType
because the parameter of methodget_mgmt_service_client
should be passed inclient_or_resource_type
, I personally think it will be more in line with the code specification.But it seems that
AzureArcVMwareManagementServiceAPI
isnon-versioned client
, so it is not suitable to define asCustomResourceType
. So please useAzureArcVMwareManagementServiceAPI
directly as before , thanks~There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms I reverted the changes.