Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vpa support #5352

Merged
merged 15 commits into from
Sep 16, 2022
Merged

Add vpa support #5352

merged 15 commits into from
Sep 16, 2022

Conversation

huizhifan
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --enable-vpa
az aks update --enable-vpa
az

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@huizhifan
Copy link
Contributor Author

Kicked off a pipeline to generate the recording file though not sure if I did it right.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 14, 2022

AKS

@FumingZhang
Copy link
Member

Kicked off a pipeline to generate the recording file though not sure if I did it right.

New pipeline

if self.context.get_enable_vpa():
if mc.workload_auto_scaler_profile is None:
mc.workload_auto_scaler_profile = self.models.ManagedClusterWorkloadAutoScalerProfile()
mc.workload_auto_scaler_profile.vertical_pod_autoscaler = self.models.ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler(enable=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if mc.workload_auto_scaler_profile.vertical_pod_autoscaler is None?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in the latest iteration

@FumingZhang
Copy link
Member

FumingZhang commented Sep 16, 2022

Kicked off a pipeline to generate the recording file though not sure if I did it right.

New pipeline

Another one, passed. Please commit the recording file from pipeline artifact to src/aks-preview/azext_aks_preview/tests/latest/recordings.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit ffcfb60 into Azure:main Sep 16, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1854690&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants