Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix #23468: az aks nodepool wait crashes with error "'Namespace' object has no attribute 'nodepool_name'" #5219

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Aug 9, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

The implementation of the az aks nodepool wait command directly calls the operation provided by the SDK, and the parameter name used to identify the nodepool name is agent_pool_name, which is different from the parameter name nodepool_name in the custom implemented nodepool commands.

The fix is to add a new dedicated validator for the command. Also added some unit tests. See sibling PR #23489.

Fix issue #23468.

Related command

az aks nodepool wait

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

Sorry, something went wrong.

@ghost ghost requested review from zhoxing-ms and wangzelin007 August 9, 2022 10:55
@ghost ghost assigned zhoxing-ms Aug 9, 2022
@ghost ghost added this to the Aug 2022 (2022-09-06) milestone Aug 9, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 9, 2022
@ghost ghost requested a review from yonzhan August 9, 2022 10:56
@ghost ghost added the AKS label Aug 9, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 9, 2022

AKS

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@FumingZhang FumingZhang force-pushed the fuming/fix-aks-nodepool-wait-0809 branch from b38215d to f61703c Compare August 10, 2022 02:39
@FumingZhang FumingZhang marked this pull request as ready for review August 10, 2022 03:01
@FumingZhang FumingZhang changed the title {AKS} az aks nodepool wait: Fix for "'Namespace' object has no attribute 'nodepool_name' error" {AKS} Fix #23468: az aks nodepool wait crashes with error "'Namespace' object has no attribute 'nodepool_name'" Aug 10, 2022
@zhoxing-ms zhoxing-ms merged commit 0cff8c1 into Azure:main Aug 10, 2022
@FumingZhang FumingZhang deleted the fuming/fix-aks-nodepool-wait-0809 branch August 22, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants