Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for arm64 Helm binaries. #5173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dcasati
Copy link

@dcasati dcasati commented Jul 29, 2022

add a condition to check what architecture we will be executing Helm (arm64 or amd64). This will ensure that we download the correct binaries for that platform. Currently, on a arm64 Mac (M1/M2 processors) we are downloading the amd64 helm binary and are using Rosetta for the translation. This breaks on any other OS (e.g.: Linux) running on aarch64.

this is a WIP as the https://k8connecthelm.azureedge.net/helm/ only contains the amd64 version of helm.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

add a condition to check what architecture we will be executing Helm (arm64 or amd64). This will ensure that we download the correct binaries for that platform. Currently, on a arm64 Mac (M1/M2 processors) we are downloading the amd64 helm binary and are using Rosetta for the translation. This breaks on any other OS (e.g.: Linux) running on aarch64.

this is a WIP as the https://k8connecthelm.azureedge.net/helm/ only contains the amd64 version of helm.
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2022

connectedk8s adds support for arm64

@yonzhan yonzhan requested review from zhoxing-ms and jsntcy July 29, 2022 23:31
@yonzhan yonzhan added this to the Aug 2022 (2022-09-06) milestone Jul 29, 2022
@XavierGeerinck
Copy link

XavierGeerinck commented Feb 27, 2023

Any update on this? (friendly ping @yonzhan)

Note: a workaround is possible by creating a symlink to the correct HELM binaries

curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash -s -- -v v3.6.3
sudo mv ~/.azure/helm/v3.6.3/linux-amd64/helm ~/.azure/helm/v3.6.3/linux-amd64/helm-old
ln -s /usr/local/bin/helm ~/.azure/helm/v3.6.3/linux-amd64/helm

@zhoxing-ms
Copy link
Contributor

@akashkeshari Could you please help review the connectedk8s extension related PR?

@bebound
Copy link
Contributor

bebound commented Mar 1, 2023

@akashkeshari CLI will support ARM64 in 2.46.0.
It would be great if this extension can also work on ARM64.

Related PR: Azure/azure-cli#24180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants