[FluidRelay] Generate fluid-relay with CodeGen v2 #5155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
|
FluidRelay |
necusjz
reviewed
Jul 26, 2022
src/fluid-relay/README.md
Outdated
| This is an extension to Azure CLI to manage FluidRelay resources. | ||
|
|
||
| ## How to use ## | ||
| Please add commands usage here. |
There was a problem hiding this comment.
It's better to have some basic use cases.
necusjz
reviewed
Jul 26, 2022
| confirmation="Are you sure you want to perform this operation?", | ||
| ) | ||
| class Delete(AAZCommand): | ||
| """Delete a Fluid Relay container. |
There was a problem hiding this comment.
It's better to complete the examples part, same as other commands.
necusjz
reviewed
Jul 26, 2022
src/service_name.json
Outdated
| { | ||
| "Command": "az fluid-relay", | ||
| "AzureServiceName": "Azure Fluid Relay", | ||
| "URL": "https://docs.microsoft.com/en-us/azure/azure-fluid-relay/overview" |
necusjz
reviewed
Jul 26, 2022
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "azext.isExperimental": true, | |||
| "azext.minCliCoreVersion": "2.38.0" | |||
There was a problem hiding this comment.
Should wait for the release of Azure CLI 2.39.0
Suggested change
| "azext.minCliCoreVersion": "2.38.0" | |
| "azext.minCliCoreVersion": "2.39.0" |
There was a problem hiding this comment.
Thank you for your correction! Relevant questions have been revised.
necusjz
changed the title
necusjz
reviewed
Jul 27, 2022
src/fluid-relay/README.md
Outdated
| This is an extension to Azure CLI to manage FluidRelay resources. | ||
|
|
||
| ## How to use ## | ||
| Please add commands usage here. |
There was a problem hiding this comment.
We can remove this hint line. :)
necusjz
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: Azure/azure-cli#22938
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az fluid-relay server create
az fluid-relay server update
az fluid-relay server list
az fluid-relay server list-key
az fluid-relay server regenerate-key
az fluid-relay server show
az fluid-relay server delete
az fluid-relay container show
az fluid-relay container list
az fluid-relay container delete
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.