Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web PubSub] Add premium tier in help and fix a bug #5149

Merged
merged 1 commit into from
Jul 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/webpubsub/azext_webpubsub/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ def load_arguments(self, _):
c.argument('webpubsub_name', webpubsub_name_type, options_list=['--name', '-n'])

with self.argument_context('webpubsub create') as c:
c.argument('sku', help='The sku name of the webpubsub service. Allowed values: Free_F1, Standard_S1')
c.argument('sku', help='The sku name of the webpubsub service. Allowed values: Free_F1, Standard_S1, Premium_P1')
c.argument('unit_count', help='The number of webpubsub service unit count', type=int)

with self.argument_context('webpubsub update') as c:
c.argument('sku', help='The sku name of the webpubsub service. Allowed values: Free_F1, Standard_S1')
c.argument('sku', help='The sku name of the webpubsub service. Allowed values: Free_F1, Standard_S1, Premium_P1')
c.argument('unit_count', help='The number of webpubsub service unit count', type=int)

with self.argument_context('webpubsub key regenerate') as c:
Expand Down
1 change: 1 addition & 0 deletions src/webpubsub/azext_webpubsub/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def webpubsub_set(client, webpubsub_name, resource_group_name, parameters):

def update_webpubsub(instance, tags=None, sku=None, unit_count=None):
sku = sku if sku else instance.sku.name
unit_count = unit_count if unit_count else instance.sku.capacity
instance.sku = ResourceSku(name=sku, capacity=unit_count)

if tags is not None:
Expand Down