Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{AKS} move KMS to GA #5148

Merged
merged 1 commit into from
Jul 27, 2022
Merged

{AKS} move KMS to GA #5148

merged 1 commit into from
Jul 27, 2022

Conversation

bingosummer
Copy link
Member

@bingosummer bingosummer commented Jul 23, 2022 •
edited
Loading

  • Do not backfill parameters in aks-preview
  • Remove "is_preview=True" from KMS parameters
  • Remove "--aks-custom-headers AKSHTTPCustomFeatures=Microsoft.ContainerService/AzureKeyVaultKmsPreview" from the test codes.

@ghost ghost requested review from zhoxing-ms and wangzelin007 July 23, 2022 12:11
@ghost ghost assigned zhoxing-ms Jul 23, 2022
@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 23, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 23, 2022
@ghost ghost requested a review from yonzhan July 23, 2022 12:11
@ghost ghost added the AKS label Jul 23, 2022
@bingosummer bingosummer changed the title {AKS} move KMS to GA WIP: {AKS} move KMS to GA Jul 23, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 24, 2022

AKS

@bingosummer bingosummer force-pushed the aks-kms-ga branch 2 times, most recently from df5fc6a to 7affd7a Compare July 25, 2022 10:30
@bingosummer
Copy link
Member Author

bingosummer commented Jul 25, 2022 •
edited
Loading

https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=58188174&view=results passed

@bingosummer bingosummer force-pushed the aks-kms-ga branch 5 times, most recently from ccf882c to a409ebe Compare July 26, 2022 10:12
@bingosummer bingosummer changed the title WIP: {AKS} move KMS to GA {AKS} move KMS to GA Jul 26, 2022
@bingosummer
Copy link
Member Author

bingosummer commented Jul 26, 2022 •
edited
Loading

https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=58198057&view=results passed

FumingZhang
FumingZhang approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 2cc1404 into Azure:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FumingZhang FumingZhang FumingZhang approved these changes

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@zhoxing-ms zhoxing-ms

Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Milestone
Jul 2022 (2022-08-02)
Development

Successfully merging this pull request may close these issues.
4 participants
@bingosummer @yonzhan @zhoxing-ms @FumingZhang