Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add az vm repair reset-nic command #5117

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Conversation

swbae31
Copy link
Contributor

@swbae31 swbae31 commented Jul 13, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Added new command:
az vm repair reset-nic

Sample call:
az vm repair reset-nic -g -n --verbose

  • Adding as preview mode until next month CLI core release rolls out and the new 'az network vnet subnet list-available-ips' is available. (Current version uses 'az network vnet list-available-ips' and it might not work at all cases)

For easy testing run these in CLI:

  1. Open Cloud shell or Azure CLI console
  2. Run:
    az extension remove -n vm-repair
    az extension add --source https://azurecomputeaidrepair.blob.core.windows.net/test/vm_repair-0.4.4-py2.py3-none-any.whl

az vm repair reset-nic -g resource-group-name -n vm-name --verbose

General Guidelines

  • [V] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [V] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

  • NOT a new extension

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from yonzhan and zhoxing-ms July 13, 2022 22:46
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 13, 2022
@ghost ghost requested a review from wangzelin007 July 13, 2022 22:46
@swbae31 swbae31 changed the title Subae/add reset nic Add az vm repair reset-nic command Jul 13, 2022
@ghost ghost assigned zhoxing-ms Jul 13, 2022
@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 13, 2022
@ghost ghost added the Compute label Jul 13, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 13, 2022

vm repair

@swbae31
Copy link
Contributor Author

swbae31 commented Jul 14, 2022

Not sure why the Extensions index is failing. It is passing on local:
image

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Jul 15, 2022

@swbae31 This is a known issue, and it has been solved by PR #5119

@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhoxing-ms
Copy link
Contributor

Could you write the description of PR change into the history notes HISTORY.rst?

@swbae31 swbae31 force-pushed the subae/AddResetNic branch from 079e727 to 88b1b99 Compare July 15, 2022 17:42
Copy link
Member

@haagha haagha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swbae31 Adding my comments.

src/vm-repair/azext_vm_repair/custom.py Show resolved Hide resolved
src/vm-repair/azext_vm_repair/custom.py Show resolved Hide resolved
src/vm-repair/azext_vm_repair/repair_utils.py Show resolved Hide resolved
@swbae31
Copy link
Contributor Author

swbae31 commented Jul 27, 2022

History updated.

@swbae31
Copy link
Contributor Author

swbae31 commented Jul 27, 2022

@zhoxing-ms can this be merged now?

@zhoxing-ms zhoxing-ms merged commit e85a4e9 into Azure:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Compute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants