-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add az vm repair reset-nic command #5117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from wangzelin007
July 13, 2022 22:46
ghost
assigned zhoxing-ms
Jul 13, 2022
ghost
added this to the Jul 2022 (2022-08-02) milestone
Jul 13, 2022
ghost
added
the
Compute
label
Jul 13, 2022
vm repair |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
zhoxing-ms
reviewed
Jul 15, 2022
zhoxing-ms
reviewed
Jul 15, 2022
Could you write the description of PR change into the history notes |
swbae31
force-pushed
the
subae/AddResetNic
branch
from
July 15, 2022 17:42
079e727
to
88b1b99
Compare
haagha
reviewed
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swbae31 Adding my comments.
History updated. |
@zhoxing-ms can this be merged now? |
zhoxing-ms
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Added new command:
az vm repair reset-nic
Sample call:
az vm repair reset-nic -g -n --verbose
For easy testing run these in CLI:
az extension remove -n vm-repair
az extension add --source https://azurecomputeaidrepair.blob.core.windows.net/test/vm_repair-0.4.4-py2.py3-none-any.whl
az vm repair reset-nic -g resource-group-name -n vm-name --verbose
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.